[all-commits] [llvm/llvm-project] 332ac2: [clang-repl] Fix building with win32 dylibs

Mateusz Mikuła via All-commits all-commits at lists.llvm.org
Mon Aug 2 11:26:31 PDT 2021


  Branch: refs/heads/release/13.x
  Home:   https://github.com/llvm/llvm-project
  Commit: 332ac2f8794610c3afdb11099a32ec36382cb500
      https://github.com/llvm/llvm-project/commit/332ac2f8794610c3afdb11099a32ec36382cb500
  Author: Martin Storsjö <martin at martin.st>
  Date:   2021-08-02 (Mon, 02 Aug 2021)

  Changed paths:
    M clang/tools/clang-repl/CMakeLists.txt

  Log Message:
  -----------
  [clang-repl] Fix building with win32 dylibs

Use `clang_target_link_libraries` to avoid duplicate libraries when
the same symbol is provided both by a static library and a larger
dylib, fixing linking with win32 dylibs. This fixes errors like
these:

    ld.lld: error: duplicate symbol: llvm::createStringError(std::__1::error_code, char const*)
    >>> defined at libLLVMSupport.a(Error.cpp.obj)
    >>> defined at libLLVM-14git.dll

This matches how other clang tools declare their dependencies.

Differential Revision: https://reviews.llvm.org/D107231

(cherry picked from commit 25a288b009f7d30b5392ea36c29570cbdcf238c3)


  Commit: a6c39006e59ce92469b3a9369ebafd7c07ef54a0
      https://github.com/llvm/llvm-project/commit/a6c39006e59ce92469b3a9369ebafd7c07ef54a0
  Author: Mateusz Mikuła <mati865 at gmail.com>
  Date:   2021-08-02 (Mon, 02 Aug 2021)

  Changed paths:
    M lld/MinGW/Options.td
    M lld/test/MinGW/driver.test

  Log Message:
  -----------
  [LLD][MinGW] Accept joined format for --stack

Postgresql uses `--stack=` in its Makefile.

Downstream issue: https://github.com/msys2/MINGW-packages/pull/9167

Reviewed By: mstorsjo

Differential Revision: https://reviews.llvm.org/D107237

(cherry picked from commit 05b025edf4aecf19634e01b0974126e53a927a50)


Compare: https://github.com/llvm/llvm-project/compare/568767b3b632...a6c39006e59c


More information about the All-commits mailing list