[all-commits] [llvm/llvm-project] 23d4c4: [flang][nfc] Fix variable names in `FrontendOption...

Andrzej WarzyƄski via All-commits all-commits at lists.llvm.org
Mon Aug 2 03:09:09 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 23d4c4f3fb12e127a5f07a7082f33b02082bb3f5
      https://github.com/llvm/llvm-project/commit/23d4c4f3fb12e127a5f07a7082f33b02082bb3f5
  Author: Andrzej Warzynski <andrzej.warzynski at arm.com>
  Date:   2021-08-02 (Mon, 02 Aug 2021)

  Changed paths:
    M flang/docs/FlangDriver.md
    M flang/include/flang/Frontend/CompilerInstance.h
    M flang/include/flang/Frontend/FrontendOptions.h
    M flang/include/flang/Frontend/PreprocessorOptions.h
    M flang/lib/Frontend/CompilerInstance.cpp
    M flang/lib/Frontend/CompilerInvocation.cpp
    M flang/lib/Frontend/FrontendAction.cpp
    M flang/lib/Frontend/FrontendActions.cpp
    M flang/lib/FrontendTool/ExecuteCompilerInvocation.cpp
    M flang/unittests/Frontend/FrontendActionTest.cpp

  Log Message:
  -----------
  [flang][nfc] Fix variable names in `FrontendOptions` & `PreprocessorOptions`

As all member variables in `FrontendOptions` and `PreprocessorOptions`
are public, we should be naming them as `variable` rather than
`variable_` [1]. This patch fixes that.

Also, `FrontendOptions` & `PreprocessorOptions` are re-defined as a
structs rather than classes (all fields are meant to be public).

[1]
https://github.com/llvm/llvm-project/blob/main/flang/docs/C%2B%2Bstyle.md#naming

Differential Revision: https://reviews.llvm.org/D107062




More information about the All-commits mailing list