[all-commits] [llvm/llvm-project] 25a288: [clang-repl] Fix building with win32 dylibs

Martin Storsjö via All-commits all-commits at lists.llvm.org
Sun Aug 1 13:02:02 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 25a288b009f7d30b5392ea36c29570cbdcf238c3
      https://github.com/llvm/llvm-project/commit/25a288b009f7d30b5392ea36c29570cbdcf238c3
  Author: Martin Storsjö <martin at martin.st>
  Date:   2021-08-01 (Sun, 01 Aug 2021)

  Changed paths:
    M clang/tools/clang-repl/CMakeLists.txt

  Log Message:
  -----------
  [clang-repl] Fix building with win32 dylibs

Use `clang_target_link_libraries` to avoid duplicate libraries when
the same symbol is provided both by a static library and a larger
dylib, fixing linking with win32 dylibs. This fixes errors like
these:

    ld.lld: error: duplicate symbol: llvm::createStringError(std::__1::error_code, char const*)
    >>> defined at libLLVMSupport.a(Error.cpp.obj)
    >>> defined at libLLVM-14git.dll

This matches how other clang tools declare their dependencies.

Differential Revision: https://reviews.llvm.org/D107231




More information about the All-commits mailing list