[all-commits] [llvm/llvm-project] 103d07: tsan: introduce Tid and StackID typedefs

Dmitry Vyukov via All-commits all-commits at lists.llvm.org
Sat Jul 31 00:05:44 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 103d075b05d1b1b70c317e662b1c31f836fcff20
      https://github.com/llvm/llvm-project/commit/103d075b05d1b1b70c317e662b1c31f836fcff20
  Author: Dmitry Vyukov <dvyukov at google.com>
  Date:   2021-07-31 (Sat, 31 Jul 2021)

  Changed paths:
    M compiler-rt/lib/sanitizer_common/sanitizer_internal_defs.h
    M compiler-rt/lib/tsan/go/tsan_go.cpp
    M compiler-rt/lib/tsan/rtl/tsan_fd.cpp
    M compiler-rt/lib/tsan/rtl/tsan_fd.h
    M compiler-rt/lib/tsan/rtl/tsan_ignoreset.cpp
    M compiler-rt/lib/tsan/rtl/tsan_ignoreset.h
    M compiler-rt/lib/tsan/rtl/tsan_interceptors_posix.cpp
    M compiler-rt/lib/tsan/rtl/tsan_platform_mac.cpp
    M compiler-rt/lib/tsan/rtl/tsan_report.cpp
    M compiler-rt/lib/tsan/rtl/tsan_report.h
    M compiler-rt/lib/tsan/rtl/tsan_rtl.cpp
    M compiler-rt/lib/tsan/rtl/tsan_rtl.h
    M compiler-rt/lib/tsan/rtl/tsan_rtl_mutex.cpp
    M compiler-rt/lib/tsan/rtl/tsan_rtl_report.cpp
    M compiler-rt/lib/tsan/rtl/tsan_rtl_thread.cpp
    M compiler-rt/lib/tsan/rtl/tsan_sync.h

  Log Message:
  -----------
  tsan: introduce Tid and StackID typedefs

Currently we inconsistently use u32 and int for thread ids,
there are also "unique tid" and "os tid" and just lots of other
things identified by integers.
Additionally new tsan runtime will introduce yet another
thread identifier that is very different from current tids.
Similarly for stack IDs, it's easy to confuse u32 with other
integer identifiers. And when a function accepts u32 or a struct
contains u32 field, it's not always clear what it is.

Add Tid and StackID typedefs to make it clear what is what.

Reviewed By: melver

Differential Revision: https://reviews.llvm.org/D107152




More information about the All-commits mailing list