[all-commits] [llvm/llvm-project] 9f5300: [mlir][spirv] Fix storing bool with proper storage...

Lei Zhang via All-commits all-commits at lists.llvm.org
Fri Jul 30 15:07:35 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 9f5300c8be4576d93256b88d195a1eb44de189f6
      https://github.com/llvm/llvm-project/commit/9f5300c8be4576d93256b88d195a1eb44de189f6
  Author: Lei Zhang <antiagainst at google.com>
  Date:   2021-07-30 (Fri, 30 Jul 2021)

  Changed paths:
    M mlir/include/mlir/Conversion/Passes.td
    M mlir/lib/Conversion/MemRefToSPIRV/MemRefToSPIRV.cpp
    M mlir/lib/Conversion/MemRefToSPIRV/MemRefToSPIRVPass.cpp
    M mlir/test/Conversion/MemRefToSPIRV/memref-to-spirv.mlir

  Log Message:
  -----------
  [mlir][spirv] Fix storing bool with proper storage capabilities

If the source value to store is bool, and we have native storage
capability support for the target bitwidth, we still cannot directly
store; we need to perform casting to match the target memref
element's bitwidth.

Reviewed By: hanchung

Differential Revision: https://reviews.llvm.org/D107114


  Commit: 0065bd2ad59cd05f0ca762a1cb586d3bfe809f2e
      https://github.com/llvm/llvm-project/commit/0065bd2ad59cd05f0ca762a1cb586d3bfe809f2e
  Author: Lei Zhang <antiagainst at google.com>
  Date:   2021-07-30 (Fri, 30 Jul 2021)

  Changed paths:
    M mlir/lib/Conversion/MemRefToSPIRV/MemRefToSPIRV.cpp
    M mlir/test/Conversion/MemRefToSPIRV/memref-to-spirv.mlir

  Log Message:
  -----------
  [mlir][spirv] Fix loading bool with proper storage capabilities

If the source value to load is bool, and we have native storage
capability support for the source bitwidth, we still cannot directly
rewrite uses; we need to perform casting to bool first.

Reviewed By: hanchung

Differential Revision: https://reviews.llvm.org/D107119


  Commit: 233a3a75ac5656257377f18f9346d407122e61b2
      https://github.com/llvm/llvm-project/commit/233a3a75ac5656257377f18f9346d407122e61b2
  Author: Lei Zhang <antiagainst at google.com>
  Date:   2021-07-30 (Fri, 30 Jul 2021)

  Changed paths:
    M mlir/lib/Target/SPIRV/Serialization/Serializer.cpp
    M mlir/test/Target/SPIRV/constant.mlir

  Log Message:
  -----------
  [mlir][spirv] Add support for i8 serialization

Reviewed By: hanchung

Differential Revision: https://reviews.llvm.org/D107122


Compare: https://github.com/llvm/llvm-project/compare/567c8c7bfd7a...233a3a75ac56


More information about the All-commits mailing list