[all-commits] [llvm/llvm-project] 986841: SelectionDAGDumper.cpp - printrWithDepthHelper - r...

Simon Pilgrim via All-commits all-commits at lists.llvm.org
Fri Jul 30 11:23:32 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 986841cca24139a20ebbcd8f8c8684aeb1812641
      https://github.com/llvm/llvm-project/commit/986841cca24139a20ebbcd8f8c8684aeb1812641
  Author: Simon Pilgrim <llvm-dev at redking.me.uk>
  Date:   2021-07-30 (Fri, 30 Jul 2021)

  Changed paths:
    M llvm/lib/CodeGen/SelectionDAG/SelectionDAGDumper.cpp

  Log Message:
  -----------
  SelectionDAGDumper.cpp - printrWithDepthHelper - remove dead code. NFCI.

Fixes coverity warning - we have an early-out for unsigned depth == 0, so the depth < 1 early-out later on is dead code.


  Commit: 3c0b596ecc618e1178efa83fb00f63178cb57010
      https://github.com/llvm/llvm-project/commit/3c0b596ecc618e1178efa83fb00f63178cb57010
  Author: Simon Pilgrim <llvm-dev at redking.me.uk>
  Date:   2021-07-30 (Fri, 30 Jul 2021)

  Changed paths:
    M llvm/lib/CodeGen/SelectionDAG/SelectionDAGDumper.cpp

  Log Message:
  -----------
  SelectionDAGDumper.cpp - remove nested if-else return chain. NFCI.

Match style and don't use an else after a return.


  Commit: afc6b09deefb6451dcb5a212f5f9db120047768b
      https://github.com/llvm/llvm-project/commit/afc6b09deefb6451dcb5a212f5f9db120047768b
  Author: Simon Pilgrim <llvm-dev at redking.me.uk>
  Date:   2021-07-30 (Fri, 30 Jul 2021)

  Changed paths:
    M llvm/lib/Transforms/InstCombine/InstCombineAndOrXor.cpp

  Log Message:
  -----------
  [InstCombine] getMaskedTypeForICmpPair - remove dead code. NFCI.

Ok should be true at this point, so the early-out is dead - replace with an assert.


Compare: https://github.com/llvm/llvm-project/compare/1d77bb9e1b82...afc6b09deefb


More information about the All-commits mailing list