[all-commits] [llvm/llvm-project] 36d53a: [OpenMP][Offloading] Remove task wait in nowait in...

Shilei Tian via All-commits all-commits at lists.llvm.org
Fri Jul 30 08:40:00 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 36d53af4a9c812e023fb6096072b906fcebf1abb
      https://github.com/llvm/llvm-project/commit/36d53af4a9c812e023fb6096072b906fcebf1abb
  Author: Shilei Tian <tianshilei1992 at gmail.com>
  Date:   2021-07-30 (Fri, 30 Jul 2021)

  Changed paths:
    M openmp/libomptarget/src/interface.cpp
    M openmp/libomptarget/src/private.h

  Log Message:
  -----------
  [OpenMP][Offloading] Remove task wait in nowait interfaces

All `nowait` series of interfaces in `libomptarget` accept four more arguments (`int32_t depNum, void *depList, int32_t noAliasDepNum, void *noAliasDepList`) compared with their counterparts w/o `nowait`. These extra arguments were expected for dependence resolution, potentially lowered to device side. Current implementation calls `libomp` function `__kmpc_omp_taskwait`. However, the front end simply ignores them, that these four arguments are not emitted at all. As a consequence, the `depNum` and `noAliasDepNum` are garbage, which could lead to unnecessary task wait.

Reviewed By: grokos

Differential Revision: https://reviews.llvm.org/D107164




More information about the All-commits mailing list