[all-commits] [llvm/llvm-project] 573465: [clangd] Make use of diagnostic tags for some clan...

kadir çetinkaya via All-commits all-commits at lists.llvm.org
Fri Jul 30 06:12:24 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 57346526c83e1fcf03baf80362fc2a9e6624f5fd
      https://github.com/llvm/llvm-project/commit/57346526c83e1fcf03baf80362fc2a9e6624f5fd
  Author: Kadir Cetinkaya <kadircet at google.com>
  Date:   2021-07-30 (Fri, 30 Jul 2021)

  Changed paths:
    M clang-tools-extra/clangd/Diagnostics.cpp
    M clang-tools-extra/clangd/Diagnostics.h
    M clang-tools-extra/clangd/Protocol.cpp
    M clang-tools-extra/clangd/Protocol.h
    M clang-tools-extra/clangd/unittests/DiagnosticsTests.cpp

  Log Message:
  -----------
  [clangd] Make use of diagnostic tags for some clang diags

It is not great to list diag ids by hand, but I don't see any other
solution unless diagnostics are annotated with these explicitly, which is a
bigger change in clang and I am not sure if would be worth it.

Diagnostics handled by this patch is by no means exhaustive, there might be
other checks that don't mention "unused"/"deprecated" in their names. But it
feels like this should be enough to catch common diagnostics and can be extended
over time.

Differential Revision: https://reviews.llvm.org/D107040




More information about the All-commits mailing list