[all-commits] [llvm/llvm-project] 17f650: tsan: s/CHECK/DCHECK/ in tsan_interface_java.cpp

Dmitry Vyukov via All-commits all-commits at lists.llvm.org
Thu Jul 29 08:13:33 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 17f650cb0078a85ec8e0d69116cf9140aca7323a
      https://github.com/llvm/llvm-project/commit/17f650cb0078a85ec8e0d69116cf9140aca7323a
  Author: Dmitry Vyukov <dvyukov at google.com>
  Date:   2021-07-29 (Thu, 29 Jul 2021)

  Changed paths:
    M compiler-rt/lib/tsan/rtl/tsan_interface_java.cpp

  Log Message:
  -----------
  tsan: s/CHECK/DCHECK/ in tsan_interface_java.cpp

We are very paranoid with CHECKs in all Java entry points.
These CHECKs were added along with Java support.
At that point it wasn't clear what exactly to expect from JVM part
and if JVM part is correct or not. Thus CHECK paranoia.
These CHECKs never fired in practice, but we pay runtime cost
in every entry point all the time.
Replace CHECKs with DCHECKs.

Depends on D107069.

Reviewed By: melver

Differential Revision: https://reviews.llvm.org/D107071




More information about the All-commits mailing list