[all-commits] [llvm/llvm-project] 486489: [Utils] Do not remove comments in llc test script

Sebastian Neubauer via All-commits all-commits at lists.llvm.org
Thu Jul 29 04:03:42 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 486489312743411ce2e25d7763e6d298f672f976
      https://github.com/llvm/llvm-project/commit/486489312743411ce2e25d7763e6d298f672f976
  Author: Sebastian Neubauer <sebastian.neubauer at amd.com>
  Date:   2021-07-29 (Thu, 29 Jul 2021)

  Changed paths:
    A llvm/test/tools/UpdateTestChecks/update_llc_test_checks/Inputs/amdgpu_no_merge_comments.ll
    A llvm/test/tools/UpdateTestChecks/update_llc_test_checks/Inputs/amdgpu_no_merge_comments.ll.expected
    A llvm/test/tools/UpdateTestChecks/update_llc_test_checks/amdgpu-no-merge-comments.test
    M llvm/utils/UpdateTestChecks/common.py
    M llvm/utils/update_analyze_test_checks.py
    M llvm/utils/update_cc_test_checks.py
    M llvm/utils/update_llc_test_checks.py
    M llvm/utils/update_test_checks.py

  Log Message:
  -----------
  [Utils] Do not remove comments in llc test script

When checking if two prefixes can be merged for a function,
update_llc_test_checks.py removed IR comments before comparing
llc outputs of different RUN lines.
This means, if one RUN line emited lines starting with ';' and another
RUN line emited the same lines except the ones starting with ';', both
RUNs would be merged (if they share a prefix).

However, CHECK-NEXT lines check the comments, otherwise they fail, so
the script should not merge RUNs if they contain different comments.

Differential Revision: https://reviews.llvm.org/D101312




More information about the All-commits mailing list