[all-commits] [llvm/llvm-project] 0c7cd4: [clang] NFC: refactor multiple implementations of ...

[Matheus Izvekov via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 0c7cd4a873138f2116403a733274c8cb7dbf925f
      https://github.com/llvm/llvm-project/commit/0c7cd4a873138f2116403a733274c8cb7dbf925f
  Author: Matheus Izvekov <mizvekov at gmail.com>
  Date:   2021-07-28 (Wed, 28 Jul 2021)

  Changed paths:
    M clang/include/clang/AST/ASTContext.h
    M clang/include/clang/Sema/Sema.h
    M clang/lib/AST/ASTContext.cpp
    M clang/lib/AST/ExprObjC.cpp
    M clang/lib/Sema/SemaConcept.cpp
    M clang/lib/Sema/SemaExpr.cpp
    M clang/lib/Sema/SemaExprCXX.cpp
    M clang/lib/Sema/SemaType.cpp
    M clang/lib/StaticAnalyzer/Core/CallEvent.cpp

  Log Message:
  -----------
  [clang] NFC: refactor multiple implementations of getDecltypeForParenthesizedExpr

This cleanup patch refactors a bunch of functional duplicates of
getDecltypeForParenthesizedExpr into a common implementation.

Signed-off-by: Matheus Izvekov <mizvekov at gmail.com>

Reviewed By: aaronpuchert

Differential Revision: https://reviews.llvm.org/D100713


  Commit: 87aa31827b293127619e2ef96e80baf709eae338
      https://github.com/llvm/llvm-project/commit/87aa31827b293127619e2ef96e80baf709eae338
  Author: Matheus Izvekov <mizvekov at gmail.com>
  Date:   2021-07-28 (Wed, 28 Jul 2021)

  Changed paths:
    M clang/lib/Sema/SemaConcept.cpp
    M clang/test/CXX/temp/temp.constr/temp.constr.normal/p1.cpp

  Log Message:
  -----------
  [clang] fix concepts crash on substitution failure during normalization

When substitution failed on the first constrained template argument (but
only the first), we would assert / crash. Checking for failure was only
being performed from the second constraint on.

This changes it so the checking is performed in that case,
and the code is also now simplified a little bit to hopefully
avoid this confusion.

Signed-off-by: Matheus Izvekov <mizvekov at gmail.com>

Reviewed By: rsmith

Differential Revision: https://reviews.llvm.org/D106907


Compare: https://github.com/llvm/llvm-project/compare/6e9e4b5a6a00...87aa31827b29