[all-commits] [llvm/llvm-project] dc5570: Revert "Revert of D49126 [PredicateInfo] Use custo...

[dobbelaj-snps via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: dc5570d149ca6a0931413bf1ad469eb8f9517f82
      https://github.com/llvm/llvm-project/commit/dc5570d149ca6a0931413bf1ad469eb8f9517f82
  Author: Jeroen Dobbelaere <jeroen.dobbelaere at synopsys.com>
  Date:   2021-07-28 (Wed, 28 Jul 2021)

  Changed paths:
    M llvm/include/llvm/Transforms/Utils/PredicateInfo.h
    M llvm/lib/Transforms/Utils/PredicateInfo.cpp
    M llvm/test/Other/debugcounter-predicateinfo.ll
    M llvm/test/Transforms/Util/PredicateInfo/condprop.ll
    M llvm/test/Transforms/Util/PredicateInfo/diamond.ll
    M llvm/test/Transforms/Util/PredicateInfo/edge.ll
    M llvm/test/Transforms/Util/PredicateInfo/testandor.ll
    M llvm/test/Transforms/Util/PredicateInfo/unnamed-types.ll

  Log Message:
  -----------
  Revert "Revert of D49126 [PredicateInfo] Use custom mangling to support ssa_copy with unnamed types."

This reverts commit 77080a1eb6061df2dcfae8ac84b85ad4d1e02031.

This change introduced issues detected with EXPENSIVE_CHECKS. Reverting to restore the
needed function cleanup. A next patch will then just improve on the name mangling.


  Commit: 03b8c69d06f810f13d0b74d06dabea37c43e5b78
      https://github.com/llvm/llvm-project/commit/03b8c69d06f810f13d0b74d06dabea37c43e5b78
  Author: Jeroen Dobbelaere <jeroen.dobbelaere at synopsys.com>
  Date:   2021-07-28 (Wed, 28 Jul 2021)

  Changed paths:
    M llvm/include/llvm/IR/Module.h
    M llvm/lib/IR/Module.cpp
    M llvm/lib/Transforms/Utils/PredicateInfo.cpp
    M llvm/test/Other/debugcounter-predicateinfo.ll
    M llvm/test/Transforms/Util/PredicateInfo/condprop.ll
    M llvm/test/Transforms/Util/PredicateInfo/diamond.ll
    M llvm/test/Transforms/Util/PredicateInfo/edge.ll
    M llvm/test/Transforms/Util/PredicateInfo/testandor.ll
    M llvm/test/Transforms/Util/PredicateInfo/unnamed-types.ll

  Log Message:
  -----------
  [PredicateInfo] Use Intrinsic::getDeclaration now that it handles unnamed types.

This is a second attempt to fix the EXPENSIVE_CHECKS issue that was mentioned  In D91661#2875179 by @jroelofs.

(The first attempt was in D105983)

D91661 more or less completely reverted D49126 and by doing so also removed the cleanup logic of the created declarations and calls.
This patch is a replacement for D91661 (which must itself be reverted first). It replaces the custom declaration creation with the
generic version and shows the test impact. It also tracks the number of NamedValues to detect if a new prototype was added instead
of looking at the available users of a prototype.

Reviewed By: jroelofs

Differential Revision: https://reviews.llvm.org/D106147


Compare: https://github.com/llvm/llvm-project/compare/71f0359a9def...03b8c69d06f8