[all-commits] [llvm/llvm-project] 5b8326: [DivRemPairs] make sure we have a valid CFG for ho...

RotateRight via All-commits all-commits at lists.llvm.org
Wed Jul 28 08:15:13 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 5b83261c1518a39636abe094123f1704bbfd972f
      https://github.com/llvm/llvm-project/commit/5b83261c1518a39636abe094123f1704bbfd972f
  Author: Sanjay Patel <spatel at rotateright.com>
  Date:   2021-07-28 (Wed, 28 Jul 2021)

  Changed paths:
    M llvm/lib/Transforms/Scalar/DivRemPairs.cpp
    M llvm/test/Transforms/DivRemPairs/X86/div-expanded-rem-pair.ll

  Log Message:
  -----------
  [DivRemPairs] make sure we have a valid CFG for hoisting division

This transform was added with e38b7e894808ec2
and as shown in:
https://llvm.org/PR51241
...it could crash without an extra check of the blocks.

There might be a more compact way to write this constraint,
but we can't just count the successors/predecessors without
affecting a test that includes a switch instruction.




More information about the All-commits mailing list