[all-commits] [llvm/llvm-project] 23326b: [mlir][spirv] Fix a few issues in ModuleCombiner

[Lei Zhang via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 23326b9f1723a398681def87c80e608fa94485f2
      https://github.com/llvm/llvm-project/commit/23326b9f1723a398681def87c80e608fa94485f2
  Author: Lei Zhang <antiagainst at google.com>
  Date:   2021-07-28 (Wed, 28 Jul 2021)

  Changed paths:
    M mlir/include/mlir/Dialect/SPIRV/IR/SPIRVOps.h
    M mlir/include/mlir/Dialect/SPIRV/IR/SPIRVStructureOps.td
    M mlir/include/mlir/Dialect/SPIRV/Linking/ModuleCombiner.h
    M mlir/lib/Conversion/GPUToSPIRV/GPUToSPIRV.cpp
    M mlir/lib/Dialect/SPIRV/IR/SPIRVOps.cpp
    M mlir/lib/Dialect/SPIRV/Linking/ModuleCombiner/ModuleCombiner.cpp
    M mlir/test/Dialect/SPIRV/Linking/ModuleCombiner/basic.mlir
    M mlir/test/Dialect/SPIRV/Linking/ModuleCombiner/conflict-resolution.mlir
    M mlir/test/Dialect/SPIRV/Linking/ModuleCombiner/deduplication.mlir
    A mlir/test/Dialect/SPIRV/Linking/ModuleCombiner/symbol-rename-listener.mlir
    M mlir/test/lib/Dialect/SPIRV/TestModuleCombiner.cpp

  Log Message:
  -----------
  [mlir][spirv] Fix a few issues in ModuleCombiner

- Fixed symbol insertion into `symNameToModuleMap`. Insertion
  needs to happen whether symbols are renamed or not.
- Added check for the VCE triple and avoid dropping it.
- Disabled function deduplication. It requires more careful
  rules. Right now it can remove different functions.
- Added tests for symbol rename listener.
- And some other code/comment cleanups.

Reviewed By: ergawy

Differential Revision: https://reviews.llvm.org/D106886