[all-commits] [llvm/llvm-project] 2aaf03: [Attributor] Update check lines for all AMDGPU att...

Johannes Doerfert via All-commits all-commits at lists.llvm.org
Mon Jul 26 22:56:55 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 2aaf038efd8cb5db4e35f8b26a0b28b6ac1bb8b1
      https://github.com/llvm/llvm-project/commit/2aaf038efd8cb5db4e35f8b26a0b28b6ac1bb8b1
  Author: Johannes Doerfert <johannes at jdoerfert.de>
  Date:   2021-07-27 (Tue, 27 Jul 2021)

  Changed paths:
    M llvm/test/CodeGen/AMDGPU/annotate-kernel-features-hsa.ll
    M llvm/test/CodeGen/AMDGPU/direct-indirect-call.ll
    M llvm/test/CodeGen/AMDGPU/duplicate-attribute-indirect.ll
    M llvm/test/CodeGen/AMDGPU/simple-indirect-call.ll

  Log Message:
  -----------
  [Attributor] Update check lines for all AMDGPU attributor tests

I thought there was only one when I pushed
cdb4cfe8b3ce2b0c50d4855ec260eab07fe63611, these should be all (in the
CodeGen/AMDGPU folder).


  Commit: 67ab875ff578588574a63d29d52f73fd25128c74
      https://github.com/llvm/llvm-project/commit/67ab875ff578588574a63d29d52f73fd25128c74
  Author: Johannes Doerfert <johannes at jdoerfert.de>
  Date:   2021-07-27 (Tue, 27 Jul 2021)

  Changed paths:
    M openmp/libomptarget/CMakeLists.txt
    A openmp/libomptarget/DeviceRTL/CMakeLists.txt
    A openmp/libomptarget/DeviceRTL/include/Configuration.h
    A openmp/libomptarget/DeviceRTL/include/Debug.h
    A openmp/libomptarget/DeviceRTL/include/Interface.h
    A openmp/libomptarget/DeviceRTL/include/Mapping.h
    A openmp/libomptarget/DeviceRTL/include/State.h
    A openmp/libomptarget/DeviceRTL/include/Synchronization.h
    A openmp/libomptarget/DeviceRTL/include/Types.h
    A openmp/libomptarget/DeviceRTL/include/Utils.h
    A openmp/libomptarget/DeviceRTL/include/generated_microtask_cases.gen
    A openmp/libomptarget/DeviceRTL/src/Configuration.cpp
    A openmp/libomptarget/DeviceRTL/src/Debug.cpp
    A openmp/libomptarget/DeviceRTL/src/Kernel.cpp
    A openmp/libomptarget/DeviceRTL/src/Mapping.cpp
    A openmp/libomptarget/DeviceRTL/src/Misc.cpp
    A openmp/libomptarget/DeviceRTL/src/Parallelism.cpp
    A openmp/libomptarget/DeviceRTL/src/Reduction.cpp
    A openmp/libomptarget/DeviceRTL/src/State.cpp
    A openmp/libomptarget/DeviceRTL/src/Synchronization.cpp
    A openmp/libomptarget/DeviceRTL/src/Tasking.cpp
    A openmp/libomptarget/DeviceRTL/src/Utils.cpp
    A openmp/libomptarget/DeviceRTL/src/Workshare.cpp

  Log Message:
  -----------
  [OpenMP] Prototype opt-in new GPU device RTL

The "old" OpenMP GPU device runtime (D14254) has served us well for many
years but modernizing it has caused some pain recently. This patch
introduces an alternative which is mostly written from scratch embracing
OpenMP 5.X, C++, LLVM coding style (where applicable), and conceptual
interfaces. This new runtime is opt-in through a clang flag (D106793).
The new runtime is currently only build for nvptx and has "-new" in its
name.

The design is tailored towards middle-end optimizations rather than
front-end code generation choices, a trend we already started in the old
runtime a while back. In contrast to the old one, state is organized in
a simple manner rather than a "smart" one. While this can induce costs
it helps optimizations. Our expectation is that the majority of codes
can be optimized and a "simple" design is therefore preferable. The new
runtime does also avoid users to pay for things they do not use,
especially wrt. memory. The unlikely case of nested parallelism is
supported but costly to make the more likely case use less resources.

The worksharing and reduction implementation have been taken from the
old runtime and will be rewritten in the future if necessary.

Documentation and debug features are still mostly missing and will be
added over time.

All external symbols start with `__kmpc` for legacy reasons but should
be renamed once we switch over to a single runtime. All internal symbols
are placed in appropriate namespaces (anonymous or `_OMP`) to avoid name
clashes with user symbols.

Differential Revision: https://reviews.llvm.org/D106803


  Commit: 75636868e2c96cb17fdfd1ed70e284ab19a15160
      https://github.com/llvm/llvm-project/commit/75636868e2c96cb17fdfd1ed70e284ab19a15160
  Author: Johannes Doerfert <johannes at jdoerfert.de>
  Date:   2021-07-27 (Tue, 27 Jul 2021)

  Changed paths:
    M llvm/include/llvm/Analysis/InstructionSimplify.h
    M llvm/lib/Analysis/InstructionSimplify.cpp

  Log Message:
  -----------
  [InstSimplify] Expose generic interface for replaced operand simplification

Users, especially the Attributor, might replace multiple operands at
once. The actual implementation of simplifyWithOpReplaced is able to
handle that just fine, the interface was simply not allowing to replace
more than one operand at a time. This is exposing a more generic
interface without intended changes for existing code.

Differential Revision: https://reviews.llvm.org/D106189


  Commit: d4bfce552110086f198ba46f37acf63df8758921
      https://github.com/llvm/llvm-project/commit/d4bfce552110086f198ba46f37acf63df8758921
  Author: Johannes Doerfert <johannes at jdoerfert.de>
  Date:   2021-07-27 (Tue, 27 Jul 2021)

  Changed paths:
    M llvm/lib/Transforms/IPO/AttributorAttributes.cpp
    M llvm/test/Transforms/Attributor/ArgumentPromotion/aggregate-promote.ll
    M llvm/test/Transforms/Attributor/ArgumentPromotion/alignment.ll
    M llvm/test/Transforms/Attributor/ArgumentPromotion/basictest.ll
    M llvm/test/Transforms/Attributor/ArgumentPromotion/chained.ll
    M llvm/test/Transforms/Attributor/ArgumentPromotion/invalidation.ll
    M llvm/test/Transforms/Attributor/IPConstantProp/PR16052.ll
    M llvm/test/Transforms/Attributor/IPConstantProp/PR26044.ll
    M llvm/test/Transforms/Attributor/IPConstantProp/dangling-block-address.ll
    M llvm/test/Transforms/Attributor/IPConstantProp/return-argument.ll
    M llvm/test/Transforms/Attributor/depgraph.ll
    M llvm/test/Transforms/Attributor/dereferenceable-1.ll
    M llvm/test/Transforms/Attributor/internal-noalias.ll
    M llvm/test/Transforms/Attributor/internalize.ll
    M llvm/test/Transforms/Attributor/liveness.ll
    M llvm/test/Transforms/Attributor/lvi-after-jumpthreading.ll
    M llvm/test/Transforms/Attributor/nonnull.ll
    M llvm/test/Transforms/Attributor/potential.ll
    M llvm/test/Transforms/Attributor/range.ll
    M llvm/test/Transforms/Attributor/value-simplify-instances.ll
    M llvm/test/Transforms/Attributor/value-simplify-pointer-info.ll
    M llvm/test/Transforms/Attributor/value-simplify.ll
    M llvm/test/Transforms/Attributor/willreturn.ll

  Log Message:
  -----------
  [Attributor] Utilize the InstSimplify interface to simplify instructions

When we simplify at least one operand in the Attributor simplification
we can use the InstSimplify to work on the simplified operands. This
allows us to avoid duplication of the logic.

Depends on D106189

Differential Revision: https://reviews.llvm.org/D106190


Compare: https://github.com/llvm/llvm-project/compare/cdb4cfe8b3ce...d4bfce552110


More information about the All-commits mailing list