[all-commits] [llvm/llvm-project] 792c20: [llvm-objcopy] Drop GRP_COMDAT if the group signat...

[Fangrui Song via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 792c206e2b63c16075d759d3abc3eb5399ed74fe
      https://github.com/llvm/llvm-project/commit/792c206e2b63c16075d759d3abc3eb5399ed74fe
  Author: Fangrui Song <i at maskray.me>
  Date:   2021-07-26 (Mon, 26 Jul 2021)

  Changed paths:
    M llvm/test/tools/llvm-objcopy/ELF/group-reorder.test
    M llvm/test/tools/llvm-objcopy/ELF/group.test
    M llvm/test/tools/llvm-objcopy/ELF/remove-section-in-group.test
    M llvm/test/tools/llvm-objcopy/ELF/strip-dwo-groups.test
    M llvm/tools/llvm-objcopy/ELF/Object.cpp

  Log Message:
  -----------
  [llvm-objcopy] Drop GRP_COMDAT if the group signature is localized

See [GRP_COMDAT group with STB_LOCAL signature](https://groups.google.com/g/generic-abi/c/2X6mR-s2zoc)
objcopy PR: https://sourceware.org/bugzilla/show_bug.cgi?id=27931

GRP_COMDAT deduplication is purely based on the signature symbol name in
ld.lld/GNU ld/gold. The local/global status is not part of the equation.

If the signature symbol is localized by --localize-hidden or
--keep-global-symbol, the intention is likely to make the group fully
localized. Drop GRP_COMDAT to suppress deduplication.

Reviewed By: jhenderson

Differential Revision: https://reviews.llvm.org/D106782