[all-commits] [llvm/llvm-project] 1139fd: [libc++][ci] Detect not committed generated files.

[mordante via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 1139fd4270c7462a4bce8e1e91e6be174dcae88f
      https://github.com/llvm/llvm-project/commit/1139fd4270c7462a4bce8e1e91e6be174dcae88f
  Author: Mark de Wever <koraq at xs4all.nl>
  Date:   2021-07-26 (Mon, 26 Jul 2021)

  Changed paths:
    M libcxx/utils/ci/buildkite-pipeline.yml
    M libcxx/utils/ci/run-buildbot

  Log Message:
  -----------
  [libc++][ci] Detect not committed generated files.

The Generated output CI job only tests for modified files. This job
should also fail the generated output contains new files.

It would be possible to test modified and untracked files in one
execution of `git ls-files`. However the diff is stored as an artifact
so the execution of `git diff` would still be required.

Discussion: Would it be better to do `git ls-files -om` and remove the
excution of
`! grep -q '^--- a' ${BUILD_DIR}/generated_output.patch || false` ?
(Obviously then the name `generated_output.untracked` should change to
something like `generated_output.status`)

Reviewed By: #libc, ldionne

Differential Revision: https://reviews.llvm.org/D106534