[all-commits] [llvm/llvm-project] 7d9a2c: Remove the NotUnderValgrind caching flag

Mehdi Amini via All-commits all-commits at lists.llvm.org
Sun Jul 25 17:25:47 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 7d9a2c714c4c198b250b65b955619a169ed9400e
      https://github.com/llvm/llvm-project/commit/7d9a2c714c4c198b250b65b955619a169ed9400e
  Author: Mehdi Amini <joker.eph at gmail.com>
  Date:   2021-07-26 (Mon, 26 Jul 2021)

  Changed paths:
    M llvm/lib/Support/Valgrind.cpp

  Log Message:
  -----------
  Remove the NotUnderValgrind caching flag

The motivation for this caching wasn't clear, remove it in an effort to
simplify the code and make libSupport free of global dynamic constructor.

Reviewed By: dexonsmith

Differential Revision: https://reviews.llvm.org/D106206


  Commit: 5eb2e9aa64b7be7cd8ed7f36de19c2c9bdf1977c
      https://github.com/llvm/llvm-project/commit/5eb2e9aa64b7be7cd8ed7f36de19c2c9bdf1977c
  Author: Mehdi Amini <joker.eph at gmail.com>
  Date:   2021-07-26 (Mon, 26 Jul 2021)

  Changed paths:
    M llvm/lib/Support/CMakeLists.txt

  Log Message:
  -----------
  Build libSupport with -Werror=global-constructors (NFC)

Ensure that libSupport does not carry any static global initializer.
libSupport can be embedded in use cases where we don't want to load all
cl::opt unless we want to parse the command line.
ManagedStatic can be used to enable lazy-initialization of globals.


Compare: https://github.com/llvm/llvm-project/compare/c2dacb1cd3cc...5eb2e9aa64b7


More information about the All-commits mailing list