[all-commits] [llvm/llvm-project] b7a464: [mlir] ConversionTarget legality callbacks refacto...

[Ivan Butygin via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: b7a464989955e6374b39b518e317b59b510d4dc5
      https://github.com/llvm/llvm-project/commit/b7a464989955e6374b39b518e317b59b510d4dc5
  Author: Butygin <ivan.butygin at intel.com>
  Date:   2021-07-24 (Sat, 24 Jul 2021)

  Changed paths:
    M mlir/include/mlir/Transforms/DialectConversion.h
    M mlir/lib/Transforms/Utils/DialectConversion.cpp

  Log Message:
  -----------
  [mlir] ConversionTarget legality callbacks refactoring

* Get rid of Optional<std::function> as std::function already have a null state
* Add private setLegalityCallback function to set legality callback for unknown ops
* Get rid of unknownOpsDynamicallyLegal flag, use unknownLegalityFn state insted. This causes behavior change when user first calls markUnknownOpDynamicallyLegal with callback and then without but I am not sure is the original behavior was really a 'feature', or just oversignt in the original implementation.

Differential Revision: https://reviews.llvm.org/D105496