[all-commits] [llvm/llvm-project] ef8c68: [source maps] fix source mapping when there are mu...

walter erquinigo via All-commits all-commits at lists.llvm.org
Fri Jul 23 17:53:29 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: ef8c6849a235e97b8b981e0f998d430fdbd7bc2a
      https://github.com/llvm/llvm-project/commit/ef8c6849a235e97b8b981e0f998d430fdbd7bc2a
  Author: Walter Erquinigo <wallace at fb.com>
  Date:   2021-07-23 (Fri, 23 Jul 2021)

  Changed paths:
    M lldb/include/lldb/Target/PathMappingList.h
    M lldb/source/Target/PathMappingList.cpp
    M lldb/test/API/tools/lldb-vscode/breakpoint/TestVSCode_setBreakpoints.py

  Log Message:
  -----------
  [source maps] fix source mapping when there are multiple matching rules

D104406 introduced an error in which, if there are multiple matchings rules for a given path, lldb was only checking for the validity in the filesystem of the first match instead of looking exhaustively one by one until a valid file is found.

Besides that, a call to consume_front was being done incorrectly, as it was modifying the input, which renders subsequent matches incorrect.

I added a test that checks for both cases.

Differential Revision: https://reviews.llvm.org/D106723




More information about the All-commits mailing list