[all-commits] [llvm/llvm-project] dc1f6f: [libomptarget][amdgpu][nfc] Drop dead signal pool ...
Jon Chesterfield via All-commits
all-commits at lists.llvm.org
Thu Jul 22 02:29:56 PDT 2021
Branch: refs/heads/main
Home: https://github.com/llvm/llvm-project
Commit: dc1f6f8b92315fb90d9694df85ae2ce7a4a4f7e0
https://github.com/llvm/llvm-project/commit/dc1f6f8b92315fb90d9694df85ae2ce7a4a4f7e0
Author: Jon Chesterfield <jonathanchesterfield at gmail.com>
Date: 2021-07-22 (Thu, 22 Jul 2021)
Changed paths:
M openmp/libomptarget/plugins/amdgpu/impl/internal.h
Log Message:
-----------
[libomptarget][amdgpu][nfc] Drop dead signal pool setup
This class is instantiated once in rtl.cpp before hsa_init is
called. The hsa_signal_create call therefore fails leaving the pool empty.
This signal pool is a legacy from ATMI where it was constructed after hsa_init.
Moving the state into the rtl.cpp global class disabled the initial populating
of the pool without noticeably changing performance. Just rechecked with a fix
that allocates the signals after hsa_init and that also doesn't noticeably
change performance.
This patch therefore drops the initialisation. Only change from main is to
drop a DEBUG_PRINT statement that would say the pool initial size is zero.
Reviewed By: jdoerfert
Differential Revision: https://reviews.llvm.org/D106515
More information about the All-commits
mailing list