[all-commits] [llvm/llvm-project] 74b8fc: sanitizer_common: revert StaticSpinMutex ctor

Dmitry Vyukov via All-commits all-commits at lists.llvm.org
Wed Jul 21 00:22:24 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 74b8fca9e4c609b4e9890b2daf6e2ff052d9dbd9
      https://github.com/llvm/llvm-project/commit/74b8fca9e4c609b4e9890b2daf6e2ff052d9dbd9
  Author: Dmitry Vyukov <dvyukov at google.com>
  Date:   2021-07-21 (Wed, 21 Jul 2021)

  Changed paths:
    M compiler-rt/lib/sanitizer_common/sanitizer_mutex.h

  Log Message:
  -----------
  sanitizer_common: revert StaticSpinMutex ctor

Patch "sanitizer_common: modernize SpinMutex" added default
ctor to StaticSpinMutex. But it broke some gcc bots with:

scudo_tsd_exclusive.cpp:25:22: error: non-local variable
‘__scudo::TSD’ declared ‘__thread’ needs dynamic initialization

https://lab.llvm.org/buildbot/#/builders/105/builds/12649

Unfortunatly none of empty ctor {}, no ctor, default constexpr ctor
work for different reasons. So remove StaticSpinMutex ctor
entirely and move deleted copy ctor back to SpinMutex.

Differential Revision: https://reviews.llvm.org/D106424




More information about the All-commits mailing list