[all-commits] [llvm/llvm-project] 1d68ec: [clang] fix oops: enable implicit moves in MSVC co...

Matheus Izvekov via All-commits all-commits at lists.llvm.org
Tue Jul 20 14:32:20 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 1d68ecafd6ad9ba8857c78e567abbc58810329c1
      https://github.com/llvm/llvm-project/commit/1d68ecafd6ad9ba8857c78e567abbc58810329c1
  Author: Matheus Izvekov <mizvekov at gmail.com>
  Date:   2021-07-20 (Tue, 20 Jul 2021)

  Changed paths:
    M clang/lib/Sema/SemaStmt.cpp
    M clang/test/SemaCXX/cxx2b-p2266-disable-with-msvc-compat.cpp

  Log Message:
  -----------
  [clang] fix oops: enable implicit moves in MSVC compatibility mode

When disabling simpler implicit moves in MSVC compatibility mode as
a workaround in D105518, we forgot to make the opposite change and
enable regular (P1825) implicit moves in the same mode.

As a result, we were not doing any implicit moves at all. OOPS!

This fixes it and adds test for this.

This is a fix to a temporary workaround, there is ongoing
work to replace this, applying the workaround only to
system headers and the ::stl namespace.

Signed-off-by: Matheus Izvekov <mizvekov at gmail.com>

Reviewed By: aaron.ballman

Differential Revision: https://reviews.llvm.org/D106303




More information about the All-commits mailing list