[all-commits] [llvm/llvm-project] 1f8d3f: [Verifier] Check byval/etc type when comparing ABI...

[Nikita Popov via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 1f8d3fd42b7c183f8fef438255e10e4e0f71d7d4
      https://github.com/llvm/llvm-project/commit/1f8d3fd42b7c183f8fef438255e10e4e0f71d7d4
  Author: Nikita Popov <nikita.ppv at gmail.com>
  Date:   2021-07-20 (Tue, 20 Jul 2021)

  Changed paths:
    M llvm/lib/IR/Verifier.cpp
    M llvm/test/Verifier/musttail-invalid.ll

  Log Message:
  -----------
  [Verifier] Check byval/etc type when comparing ABI attributes

For musttail calls, ABI attributes between the function and the
musttail call must match. The current check discards the type of
type attributes like byval, which means that it will consider
byval(i32) and byval(i64) (or similar) as compatible.

I assume this is a leftover from before these attributes had a
type argument. Ran into this while trying to tighten an assertion
in AttrBuilder.

Differential Revision: https://reviews.llvm.org/D105841


  Commit: 0c794abff12db9d3d307b744029a9eb67308fa2c
      https://github.com/llvm/llvm-project/commit/0c794abff12db9d3d307b744029a9eb67308fa2c
  Author: Nikita Popov <nikita.ppv at gmail.com>
  Date:   2021-07-20 (Tue, 20 Jul 2021)

  Changed paths:
    M llvm/lib/Transforms/IPO/ThinLTOBitcodeWriter.cpp

  Log Message:
  -----------
  [ThinTLOBitcodeWriter] Fix unused variable warning (NFC)


Compare: https://github.com/llvm/llvm-project/compare/c68f247275ee...0c794abff12d