[all-commits] [llvm/llvm-project] adb55d: tsan: remove the stats subsystem

Dmitry Vyukov via All-commits all-commits at lists.llvm.org
Mon Jul 19 22:47:52 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: adb55d7c326559e99f1eeb3234cdfaaf3c9010de
      https://github.com/llvm/llvm-project/commit/adb55d7c326559e99f1eeb3234cdfaaf3c9010de
  Author: Dmitry Vyukov <dvyukov at google.com>
  Date:   2021-07-20 (Tue, 20 Jul 2021)

  Changed paths:
    M compiler-rt/lib/tsan/CMakeLists.txt
    M compiler-rt/lib/tsan/go/build.bat
    M compiler-rt/lib/tsan/go/buildgo.sh
    M compiler-rt/lib/tsan/rtl/tsan_clock.cpp
    M compiler-rt/lib/tsan/rtl/tsan_defs.h
    M compiler-rt/lib/tsan/rtl/tsan_interface_ann.cpp
    M compiler-rt/lib/tsan/rtl/tsan_interface_atomic.cpp
    M compiler-rt/lib/tsan/rtl/tsan_mman.cpp
    M compiler-rt/lib/tsan/rtl/tsan_mutex.cpp
    M compiler-rt/lib/tsan/rtl/tsan_mutex.h
    M compiler-rt/lib/tsan/rtl/tsan_rtl.cpp
    M compiler-rt/lib/tsan/rtl/tsan_rtl.h
    M compiler-rt/lib/tsan/rtl/tsan_rtl_mutex.cpp
    M compiler-rt/lib/tsan/rtl/tsan_rtl_thread.cpp
    R compiler-rt/lib/tsan/rtl/tsan_stat.cpp
    R compiler-rt/lib/tsan/rtl/tsan_stat.h
    M compiler-rt/lib/tsan/rtl/tsan_sync.cpp
    M compiler-rt/lib/tsan/rtl/tsan_trace.h
    M compiler-rt/lib/tsan/rtl/tsan_update_shadow_word_inl.h
    M compiler-rt/lib/tsan/tests/unit/tsan_mutex_test.cpp

  Log Message:
  -----------
  tsan: remove the stats subsystem

I don't think the stat subsystem was ever used since tsan
development in 2012. But it adds lots of code and this
effectively dead code needs to be updated if the runtime
code changes, which adds maintanance cost for no benefit.
Normal profiler usually gives enough info and that info
is more trustworthy.
Remove the stats subsystem.

Reviewed By: vitalybuka

Differential Revision: https://reviews.llvm.org/D106276




More information about the All-commits mailing list