[all-commits] [llvm/llvm-project] 2656af: Don't use !eStateRunning when you mean eStateStopp...

[jimingham via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 2656af95eb8e67364db7b8dc4a95c3b65c286b2d
      https://github.com/llvm/llvm-project/commit/2656af95eb8e67364db7b8dc4a95c3b65c286b2d
  Author: Jim Ingham <jingham at apple.com>
  Date:   2021-07-19 (Mon, 19 Jul 2021)

  Changed paths:
    M lldb/source/Target/Process.cpp

  Log Message:
  -----------
  Don't use !eStateRunning when you mean eStateStopped in DestroyImpl.

When we go to destroy the process, we first try to halt it, if
we succeeded and the target stopped, we want to clear out the
thread plans and breakpoints in case we still need to resume to complete
killing the process.  If the target was exited or detached, it's
pointless but harmless to do this.  But if the state is eStateInvalid -
for instance if we tried to interrupt the target to Halt it and that
fails - we don't want to keep trying to interact with the inferior,
so we shouldn't do this work.

This change explicitly checks eStateStopped, and only does the pre-resume
cleanup if we did manage to stop the process.