[all-commits] [llvm/llvm-project] f4f11e: [mlir][NFC] Switched `interfaces` to a private mem...

[itaiz-google via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: f4f11ee4a705761e3dfc6c678412831f770f71d6
      https://github.com/llvm/llvm-project/commit/f4f11ee4a705761e3dfc6c678412831f770f71d6
  Author: Itai Zukerman <itaiz at google.com>
  Date:   2021-07-10 (Sat, 10 Jul 2021)

  Changed paths:
    M mlir/lib/IR/AsmPrinter.cpp

  Log Message:
  -----------
  [mlir][NFC] Switched `interfaces` to a private member of SSANameState.

`interfaces` is passed through to the `numberValuesIn*` functions with exactly
the same value as when SSANameState is constructed.  This just seems cleaner.

Also, a dependent PR adds `printerFlags` which follows similar code paths.

Reviewed By: mehdi_amini

Differential Revision: https://reviews.llvm.org/D105299


  Commit: 2c0f17982f39b14c7ed13069d6ed959ef43d02d9
      https://github.com/llvm/llvm-project/commit/2c0f17982f39b14c7ed13069d6ed959ef43d02d9
  Author: Itai Zukerman <itaiz at google.com>
  Date:   2021-07-10 (Sat, 10 Jul 2021)

  Changed paths:
    M mlir/include/mlir/IR/AsmState.h
    M mlir/include/mlir/IR/Operation.h
    M mlir/lib/IR/AsmPrinter.cpp
    M mlir/lib/Transforms/LocationSnapshot.cpp

  Log Message:
  -----------
  [mlir] Added OpPrintingFlags to AsmState and SSANameState.

This enables checking the printing flags when formatting names
in SSANameState.

Depends On D105299

Reviewed By: mehdi_amini, bondhugula

Differential Revision: https://reviews.llvm.org/D105300


  Commit: ebbe149a6f08535ede848a531a601ae6591cfbc5
      https://github.com/llvm/llvm-project/commit/ebbe149a6f08535ede848a531a601ae6591cfbc5
  Author: Itai Zukerman <itaiz at google.com>
  Date:   2021-07-10 (Sat, 10 Jul 2021)

  Changed paths:
    M mlir/lib/IR/AsmPrinter.cpp
    A mlir/test/IR/print-op-generic.mlir
    M mlir/test/mlir-lsp-server/hover.test

  Log Message:
  -----------
  [mlir] Gated calls to getAsm{Result,BlockArgument}Names on whether printing ops in generic form.

Depends On D105300

Reviewed By: mehdi_amini

Differential Revision: https://reviews.llvm.org/D105301


Compare: https://github.com/llvm/llvm-project/compare/d99f65de2ab1...ebbe149a6f08