[all-commits] [llvm/llvm-project] 8cf60e: [mlir][sparse] updated setter/getter comments

Aart Bik via All-commits all-commits at lists.llvm.org
Thu Jul 8 09:36:43 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 8cf60e61e7b0e3213b5b81039878dcf1ef18c00f
      https://github.com/llvm/llvm-project/commit/8cf60e61e7b0e3213b5b81039878dcf1ef18c00f
  Author: Aart Bik <ajcbik at google.com>
  Date:   2021-07-08 (Thu, 08 Jul 2021)

  Changed paths:
    M mlir/include/mlir/Dialect/SparseTensor/Utils/Merger.h

  Log Message:
  -----------
  [mlir][sparse] updated setter/getter comments

For the getters, it is bad practice to keep the reference
around for too long, as explained in the new comment

Reviewed By: gussmith23

Differential Revision: https://reviews.llvm.org/D105599




More information about the All-commits mailing list