[all-commits] [llvm/llvm-project] 3e6d2c: [mlir] Fully qualify types and expressions in Inte...

[zero9178 via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 3e6d2cbf268e66e350ebd321345c7d846933da68
      https://github.com/llvm/llvm-project/commit/3e6d2cbf268e66e350ebd321345c7d846933da68
  Author: Markus Böck <markus.boeck02 at gmail.com>
  Date:   2021-07-08 (Thu, 08 Jul 2021)

  Changed paths:
    M mlir/include/mlir/Interfaces/CallInterfaces.td
    M mlir/include/mlir/Interfaces/CastInterfaces.td
    M mlir/include/mlir/Interfaces/ControlFlowInterfaces.td
    M mlir/include/mlir/Interfaces/DataLayoutInterfaces.td
    M mlir/include/mlir/Interfaces/DerivedAttributeOpInterface.td
    M mlir/include/mlir/Interfaces/InferTypeOpInterface.td
    M mlir/include/mlir/Interfaces/SideEffectInterfaceBase.td
    M mlir/include/mlir/Interfaces/VectorInterfaces.td
    M mlir/include/mlir/Interfaces/ViewLikeInterface.td

  Log Message:
  -----------
  [mlir] Fully qualify types and expressions in Interfaces

This patch adds full qualification to the types and function calls used inside of (Static)InterfaceMethod in OpInterfaces. Without this patch using many of these interfaces in a downstream project yields compiler errors as the types and default implementations are mostly copied verbatim. Without then putting using namespace mlir; in the header file of the implementations of those interfaces, compilation is impossible.

Using fully qualified lookup fixes this issue.

Differential Revision: https://reviews.llvm.org/D105619