[all-commits] [llvm/llvm-project] d338e7: [OpaquePtr] Remove checking pointee type for byval...

[aeubanks via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: d338e79a4cc1d52a6b5a1a241c2318a7288c0240
      https://github.com/llvm/llvm-project/commit/d338e79a4cc1d52a6b5a1a241c2318a7288c0240
  Author: Arthur Eubanks <aeubanks at google.com>
  Date:   2021-07-07 (Wed, 07 Jul 2021)

  Changed paths:
    M llvm/include/llvm/IR/InstrTypes.h
    M llvm/unittests/IR/AttributesTest.cpp

  Log Message:
  -----------
  [OpaquePtr] Remove checking pointee type for byval/preallocated type

These currently always require a type parameter. The bitcode reader
already upgrades old bitcode without the type parameter to use the
pointee type.

In cases where the caller does not have byval but the callee does, we
need to follow CallBase::paramHasAttr() and also look at the callee for
the byval type so that CallBase::isByValArgument() and
CallBase::getParamByValType() are in sync. Do the same for preallocated.

While we're here add a corresponding version for inalloca since we'll
need it soon.

Reviewed By: nikic

Differential Revision: https://reviews.llvm.org/D104663