[all-commits] [llvm/llvm-project] 6e43f3: [libc++] Do not set CMAKE_BUILD_WITH_INSTALL_NAME_DIR

Louis Dionne via All-commits all-commits at lists.llvm.org
Tue Jul 6 11:47:11 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 6e43f3fc141f73a50638aab159de92c1c6d257da
      https://github.com/llvm/llvm-project/commit/6e43f3fc141f73a50638aab159de92c1c6d257da
  Author: Louis Dionne <ldionne.2 at gmail.com>
  Date:   2021-07-06 (Tue, 06 Jul 2021)

  Changed paths:
    M libcxx/CMakeLists.txt
    M libcxx/utils/ci/runtimes/CMakeLists.txt

  Log Message:
  -----------
  [libc++] Do not set CMAKE_BUILD_WITH_INSTALL_NAME_DIR

I'm not sure what that gains us, and it creates a problem when
trying to run the tests against libc++ with a custom install name
dir (e.g. /usr/lib), since the library that we link against (in
the build tree) will advertise itself as /usr/lib/libc++.dylib,
so we end up linking against the system dylib at runtime.

Differential Revision: https://reviews.llvm.org/D105499




More information about the All-commits mailing list