[all-commits] [llvm/llvm-project] 74d6ce: [ScalarEvolution] Make getMinusSCEV() fail for unr...

[Eli Friedman via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 74d6ce5d5f169e9cf3fac0eb1042602e286dd2b9
      https://github.com/llvm/llvm-project/commit/74d6ce5d5f169e9cf3fac0eb1042602e286dd2b9
  Author: Eli Friedman <efriedma at quicinc.com>
  Date:   2021-07-06 (Tue, 06 Jul 2021)

  Changed paths:
    M llvm/include/llvm/Analysis/ScalarEvolution.h
    M llvm/lib/Analysis/ScalarEvolution.cpp
    M llvm/lib/Analysis/ScalarEvolutionAliasAnalysis.cpp
    M llvm/lib/Analysis/StackSafetyAnalysis.cpp
    M llvm/lib/Transforms/Scalar/AlignmentFromAssumptions.cpp
    M llvm/lib/Transforms/Scalar/LoopRerollPass.cpp
    M llvm/lib/Transforms/Scalar/LoopStrengthReduce.cpp
    M llvm/test/Analysis/StackSafetyAnalysis/local.ll
    R llvm/test/CodeGen/ARM/lsr-undef-in-binop.ll
    M llvm/test/CodeGen/ARM/test-sharedidx.ll
    M llvm/test/CodeGen/PowerPC/pr42492.ll
    M llvm/test/CodeGen/X86/update-terminator-debugloc.ll
    M llvm/test/Transforms/LoopStrengthReduce/AMDGPU/lsr-postinc-pos-addrspace.ll
    M llvm/test/Transforms/LoopStrengthReduce/X86/eh-insertion-point-2.ll
    M llvm/test/Transforms/LoopStrengthReduce/X86/eh-insertion-point.ll
    M llvm/test/Transforms/LoopStrengthReduce/X86/expander-crashes.ll
    M llvm/test/Transforms/LoopStrengthReduce/X86/expander-reused-value-insert-point.ll
    M llvm/test/Transforms/LoopStrengthReduce/X86/ivchain-X86.ll
    M llvm/test/Transforms/LoopStrengthReduce/funclet.ll
    M llvm/test/Transforms/LoopStrengthReduce/pr27056.ll

  Log Message:
  -----------
  [ScalarEvolution] Make getMinusSCEV() fail for unrelated pointers.

As part of making ScalarEvolution's handling of pointers consistent, we
want to forbid multiplying a pointer by -1 (or any other value). This
means we can't blindly subtract pointers.

There are a few ways we could deal with this:
1. We could completely forbid subtracting pointers in getMinusSCEV()
2. We could forbid subracting pointers with different pointer bases
(this patch).
3. We could try to ptrtoint pointer operands.

The option in this patch is more friendly to non-integral pointers: code
that works with normal pointers will also work with non-integral
pointers. And it seems like there are very few places that actually
benefit from the third option.

As a minimal patch, the ScalarEvolution implementation of getMinusSCEV
still ends up subtracting pointers if they have the same base.  This
should eliminate the shared pointer base, but eventually we'll need to
rewrite it to avoid negating the pointer base. I plan to do this as a
separate step to allow measuring the compile-time impact.

This doesn't cause obvious functional changes in most cases; the one
case that is significantly affected is ICmpZero handling in LSR (which
is the source of almost all the test changes).  The resulting changes
seem okay to me, but suggestions welcome.  As an alternative, I tried
explicitly ptrtoint'ing the operands, but the result doesn't seem
obviously better.

I deleted the test lsr-undef-in-binop.ll becuase I couldn't figure out
how to repair it to test what it was actually trying to test.

Differential Revision: https://reviews.llvm.org/D104806