[all-commits] [llvm/llvm-project] dadedc: [InstCombine] visitUnreachableInst(): iteratively ...

[Roman Lebedev via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: dadedc99e9b276cfd0f2ebf9eb553650b07b4ca4
      https://github.com/llvm/llvm-project/commit/dadedc99e9b276cfd0f2ebf9eb553650b07b4ca4
  Author: Roman Lebedev <lebedev.ri at gmail.com>
  Date:   2021-07-02 (Fri, 02 Jul 2021)

  Changed paths:
    M llvm/lib/Transforms/InstCombine/InstructionCombining.cpp

  Log Message:
  -----------
  [InstCombine] visitUnreachableInst(): iteratively erase instructions leading to unreachable

In the original review D87149 it was mentioned that this approach was tried,
and it lead to infinite combine loops, but i'm not seeing anything like that now,
neither in the `check-llvm`, nor on some codebases i tried.

This is a recommit of d9d65527c289fb27a9f92f150723bbb3c58e413f,
which i immediately reverted because i have messed up something
during branch switch, and 597ccc92ce4b0f90883406d1f78d9d776f602804
accidentally ended up being pushed, which was very much not the intention.

Reviewed By: spatel

Differential Revision: https://reviews.llvm.org/D105339