[all-commits] [llvm/llvm-project] 597ccc: https://godbolt.org/z/5vhv4K5b8

Roman Lebedev via All-commits all-commits at lists.llvm.org
Fri Jul 2 07:17:30 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 597ccc92ce4b0f90883406d1f78d9d776f602804
      https://github.com/llvm/llvm-project/commit/597ccc92ce4b0f90883406d1f78d9d776f602804
  Author: Roman Lebedev <lebedev.ri at gmail.com>
  Date:   2021-07-02 (Fri, 02 Jul 2021)

  Changed paths:
    M llvm/lib/Transforms/Utils/SimplifyCFG.cpp
    M llvm/test/Transforms/SimplifyCFG/trapping-load-unreachable.ll

  Log Message:
  -----------
  https://godbolt.org/z/5vhv4K5b8


  Commit: d9d65527c289fb27a9f92f150723bbb3c58e413f
      https://github.com/llvm/llvm-project/commit/d9d65527c289fb27a9f92f150723bbb3c58e413f
  Author: Roman Lebedev <lebedev.ri at gmail.com>
  Date:   2021-07-02 (Fri, 02 Jul 2021)

  Changed paths:
    M llvm/lib/Transforms/InstCombine/InstructionCombining.cpp

  Log Message:
  -----------
  [NFCI][InstCombine] visitUnreachableInst(): iteratively erase instructions leading to unreachable

In the original review D87149 it was mentioned that this approach was tried,
and it lead to infinite combine loops, but i'm not seeing anything like that now,
neither in the `check-llvm`, nor on some codebases i tried.

Reviewed By: spatel

Differential Revision: https://reviews.llvm.org/D105339


Compare: https://github.com/llvm/llvm-project/compare/fff966b6855a...d9d65527c289


More information about the All-commits mailing list