[all-commits] [llvm/llvm-project] 26e155: [clangd] CMake: express -Iclangd/ at top level and...

[Sam McCall via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 26e1553a107f52667be879e99739a4153f8799d8
      https://github.com/llvm/llvm-project/commit/26e1553a107f52667be879e99739a4153f8799d8
  Author: Sam McCall <sam.mccall at gmail.com>
  Date:   2021-07-02 (Fri, 02 Jul 2021)

  Changed paths:
    M clang-tools-extra/clangd/CMakeLists.txt
    M clang-tools-extra/clangd/benchmarks/CMakeLists.txt
    M clang-tools-extra/clangd/benchmarks/CompletionModel/CMakeLists.txt
    M clang-tools-extra/clangd/fuzzer/CMakeLists.txt
    M clang-tools-extra/clangd/index/dex/dexp/CMakeLists.txt
    M clang-tools-extra/clangd/index/remote/CMakeLists.txt
    M clang-tools-extra/clangd/indexer/CMakeLists.txt
    M clang-tools-extra/clangd/support/CMakeLists.txt
    M clang-tools-extra/clangd/tool/CMakeLists.txt
    M clang-tools-extra/clangd/unittests/CMakeLists.txt
    M clang-tools-extra/clangd/unittests/xpc/CMakeLists.txt
    M clang-tools-extra/clangd/xpc/CMakeLists.txt
    M clang-tools-extra/clangd/xpc/test-client/CMakeLists.txt

  Log Message:
  -----------
  [clangd] CMake: express -Iclangd/ at top level and inherit

For files directly under clangd/, -Iclang-tools-extra/clangd (and the
equivalent for generated files) are not required, as CMake/the compiler puts
these directories on the include path by default.

However this means each subdirectory needs to
include_directories(.. ${CMAKE_CURRENT_BINARY_DIR}/..) etc, and this
proved annoying and error-prone to maintain and debug.

Since include_directories is inherited by subdirectories, we just
configure this explicitly at the top level instead.