[all-commits] [llvm/llvm-project] 0f1f92: [ARM] Fix incorrect assignment of Changed variable...

Craig Topper via All-commits all-commits at lists.llvm.org
Wed Jun 30 07:53:11 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 0f1f92156f3caafe9567b853ecb57212b709e68d
      https://github.com/llvm/llvm-project/commit/0f1f92156f3caafe9567b853ecb57212b709e68d
  Author: Craig Topper <craig.topper at sifive.com>
  Date:   2021-06-30 (Wed, 30 Jun 2021)

  Changed paths:
    M llvm/lib/Target/ARM/MVEGatherScatterLowering.cpp

  Log Message:
  -----------
  [ARM] Fix incorrect assignment of Changed variable in MVEGatherScatterLowering::optimiseOffsets.

I believe this Changed flag should be initialized to false,
otherwise the if (!Changed) is always dead. This doesn't
manifest in a functional issue because the PHINode checks will
fail if nothing changed. They are identical to the earlier
checks that must have already failed to get into this else block.

While there remove an else after return to reduce indentation.

Differential Revision: https://reviews.llvm.org/D105159




More information about the All-commits mailing list