[all-commits] [llvm/llvm-project] d4dcb5: [llvm-readobj] Make -s and -t match llvm-readelf

Fangrui Song via All-commits all-commits at lists.llvm.org
Tue Jun 29 11:56:38 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: d4dcb55c7050fd908af2378fa551078d859d994f
      https://github.com/llvm/llvm-project/commit/d4dcb55c7050fd908af2378fa551078d859d994f
  Author: Fangrui Song <i at maskray.me>
  Date:   2021-06-29 (Tue, 29 Jun 2021)

  Changed paths:
    M llvm/docs/CommandGuide/llvm-readobj.rst
    M llvm/docs/ReleaseNotes.rst
    M llvm/test/tools/llvm-readobj/ELF/merged.test
    M llvm/test/tools/llvm-readobj/ELF/sections.test
    M llvm/test/tools/llvm-readobj/ELF/symbols.test
    M llvm/test/tools/llvm-readobj/basic.test
    M llvm/test/tools/yaml2obj/ELF/duplicate-symbol-names.yaml
    M llvm/tools/llvm-readobj/llvm-readobj.cpp

  Log Message:
  -----------
  [llvm-readobj] Make -s and -t match llvm-readelf

llvm-readobj is an internal testing tool for binary formats. Its output and
command line options do not need to be stable. It isn't supposed to be part of a
build process.

llvm-readelf was created as a user-facing utility and its interface intends to
be compatible with GNU readelf (unless there are good reasons not to).

The two tools have mostly compatible options. -s and -t are noticeable
exceptions due to history. I think the cost of keeping the inconsistency
overweighs the little history-compatible benefit and hinders transition from
cl::opt to OptTable, so let's change it.

Reviewed By: jhenderson

Differential Revision: https://reviews.llvm.org/D105055




More information about the All-commits mailing list