[all-commits] [llvm/llvm-project] a8a6e5: [lld-macho] Preserve alignment for non-deduplicate...

Leonard Grey via All-commits all-commits at lists.llvm.org
Mon Jun 28 19:27:04 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: a8a6e5b094aac642f436390294ec837400c521bb
      https://github.com/llvm/llvm-project/commit/a8a6e5b094aac642f436390294ec837400c521bb
  Author: Leonard Grey <lgrey at chromium.org>
  Date:   2021-06-28 (Mon, 28 Jun 2021)

  Changed paths:
    M lld/MachO/InputFiles.cpp
    M lld/MachO/InputSection.cpp
    M lld/MachO/InputSection.h
    M lld/MachO/SyntheticSections.cpp
    M lld/MachO/SyntheticSections.h
    M lld/MachO/Writer.cpp
    A lld/test/MachO/dead-strip-align.s
    R lld/test/MachO/subsections-section-relocs.s

  Log Message:
  -----------
  [lld-macho] Preserve alignment for non-deduplicated cstrings

Fixes PR50637.

Downstream bug: https://crbug.com/1218958

Currently, we split __cstring along symbol boundaries with .subsections_via_symbols
when not deduplicating, and along null bytes when deduplicating. This change splits
along null bytes unconditionally, and preserves original alignment in the non-
deduplicated case.

Removing subsections-section-relocs.s because with this change, __cstring
is never reordered based on the order file.

Differential Revision: https://reviews.llvm.org/D104919




More information about the All-commits mailing list