[all-commits] [llvm/llvm-project] 355541: [lldb] Avoid using any shell when calling xcrun.

Raphael Isemann via All-commits all-commits at lists.llvm.org
Mon Jun 28 10:54:18 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 355541a1b7a5011f8f4ebadc3e23b25c734f9d27
      https://github.com/llvm/llvm-project/commit/355541a1b7a5011f8f4ebadc3e23b25c734f9d27
  Author: Raphael Isemann <teemperor at gmail.com>
  Date:   2021-06-28 (Mon, 28 Jun 2021)

  Changed paths:
    M lldb/source/Host/macosx/objcxx/HostInfoMacOSX.mm

  Log Message:
  -----------
  [lldb] Avoid using any shell when calling xcrun.

When we run `xcrun` we don't have any user input in our command so relying on
the user's default shell doesn't make a lot of sense. If the user has set the
system shell to a something that isn't supported yet (dash, ash) then we would
run into the problem that we don't know how to escape our command string.

This patch just avoids using any shell at all as xcrun is always at the same
path.

Reviewed By: aprantl, JDevlieghere, kastiglione

Differential Revision: https://reviews.llvm.org/D104653




More information about the All-commits mailing list