[all-commits] [llvm/llvm-project] 50ad34: Disable ReplaceLDS pass, patch up tests to match

Jon Chesterfield via All-commits all-commits at lists.llvm.org
Fri Jun 25 17:37:02 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 50ad3478bdd3f0643ee94f6663293af5b3c27afe
      https://github.com/llvm/llvm-project/commit/50ad3478bdd3f0643ee94f6663293af5b3c27afe
  Author: Jon Chesterfield <jonathanchesterfield at gmail.com>
  Date:   2021-06-26 (Sat, 26 Jun 2021)

  Changed paths:
    M llvm/lib/Target/AMDGPU/AMDGPUTargetMachine.cpp
    M llvm/test/CodeGen/AMDGPU/llc-pipeline.ll
    M llvm/test/CodeGen/AMDGPU/replace-lds-by-ptr-call-diamond-shape.ll
    M llvm/test/CodeGen/AMDGPU/replace-lds-by-ptr-call-selected_functions.ll
    M llvm/test/CodeGen/AMDGPU/replace-lds-by-ptr-ignore-global-scope-use.ll
    M llvm/test/CodeGen/AMDGPU/replace-lds-by-ptr-ignore-inline-asm-call.ll
    M llvm/test/CodeGen/AMDGPU/replace-lds-by-ptr-ignore-kernel-only-used-lds.ll
    M llvm/test/CodeGen/AMDGPU/replace-lds-by-ptr-ignore-not-reachable-lds.ll
    M llvm/test/CodeGen/AMDGPU/replace-lds-by-ptr-ignore-small-lds.ll
    M llvm/test/CodeGen/AMDGPU/replace-lds-by-ptr-indirect-call-diamond-shape.ll
    M llvm/test/CodeGen/AMDGPU/replace-lds-by-ptr-indirect-call-selected_functions.ll
    M llvm/test/CodeGen/AMDGPU/replace-lds-by-ptr-indirect-call-signature-match.ll
    R llvm/test/CodeGen/AMDGPU/replace-lds-by-ptr-lds-offsets.ll
    M llvm/test/CodeGen/AMDGPU/replace-lds-by-ptr-use-multiple-lds.ll
    M llvm/test/CodeGen/AMDGPU/replace-lds-by-ptr-use-same-lds.ll
    M llvm/test/CodeGen/AMDGPU/replace-lds-by-ptr-use-within-const-expr1.ll
    M llvm/test/CodeGen/AMDGPU/replace-lds-by-ptr-use-within-const-expr2.ll
    M llvm/test/CodeGen/AMDGPU/replace-lds-by-ptr-use-within-phi-inst.ll

  Log Message:
  -----------
  Disable ReplaceLDS pass, patch up tests to match

Most tests passed with an extra argument to explicitly enable the pass.
One does not, deleted it as part of this change. I can't see why the codegen
would be different between default on and default off but switched on. It
can be retrieved from the project history.

This would be a revert, but git revert was not clean. Disabling the pass
and leaving it in tree is less likely to cause breakage elsewhere than
patching up the git revert conflicts on unfamiliar code. It'll be landed
without review, as @hsmhsm is believed unavailable at present.

Differential Revision: https://reviews.llvm.org/D104962




More information about the All-commits mailing list