[all-commits] [llvm/llvm-project] 363808: [Coroutines] Define __coro_frame_ty in function scope

Hongtao Yu via All-commits all-commits at lists.llvm.org
Fri Jun 25 12:33:43 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 3638085ff01332afbd2eb555a32821802f0643c8
      https://github.com/llvm/llvm-project/commit/3638085ff01332afbd2eb555a32821802f0643c8
  Author: Hongtao Yu <hoy at fb.com>
  Date:   2021-06-25 (Fri, 25 Jun 2021)

  Changed paths:
    M llvm/lib/Transforms/Coroutines/CoroFrame.cpp
    M llvm/test/Transforms/Coroutines/coro-debug-coro-frame.ll

  Log Message:
  -----------
  [Coroutines] Define __coro_frame_ty in function scope

Types should be defined in function scope instead of a local lexical scope. Field types should be defined inside in its parent type scope.

We were seeing a type defined in a local scope causing trouble to the dwarf emitter where a context is required to be a funciton scope, a namespace or a global scope.

Reviewed By: aprantl

Differential Revision: https://reviews.llvm.org/D104937




More information about the All-commits mailing list