[all-commits] [llvm/llvm-project] 6e5c4a: [lldb] Re-enable GDB server client memory tag read...
David Spickett via All-commits
all-commits at lists.llvm.org
Fri Jun 25 03:10:35 PDT 2021
Branch: refs/heads/main
Home: https://github.com/llvm/llvm-project
Commit: 6e5c4a443d7e354a37d7dcb82a65216679ab1b40
https://github.com/llvm/llvm-project/commit/6e5c4a443d7e354a37d7dcb82a65216679ab1b40
Author: David Spickett <david.spickett at linaro.org>
Date: 2021-06-25 (Fri, 25 Jun 2021)
Changed paths:
M lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp
M lldb/unittests/Process/gdb-remote/GDBRemoteCommunicationClientTest.cpp
Log Message:
-----------
[lldb] Re-enable GDB server client memory tag read tests
These were disabled in 473a3a773ea565612e836ae6c2093178c5a9eb72
because they failed on 32 bit platforms. (Arm for sure but I assume
any 32 bit)
This was due to the printf formatter used. These assumed
that types like uint64_t/size_t would be certain size/type and
that changes on 32 bit.
Instead use "z" to print the size_t and PRI<...> formatters
for the addr_t (always uint64_t) and the int32_t.
More information about the All-commits
mailing list