[all-commits] [llvm/llvm-project] d07f43: [LLD] [COFF] Fix handling of LTO comdats with nont...

[Martin Storsjö via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: d07f43641f98a8e0024cf8e94ef98c7c912221d9
      https://github.com/llvm/llvm-project/commit/d07f43641f98a8e0024cf8e94ef98c7c912221d9
  Author: Martin Storsjö <martin at martin.st>
  Date:   2021-06-25 (Fri, 25 Jun 2021)

  Changed paths:
    M lld/COFF/InputFiles.cpp
    A lld/test/COFF/lto-comdat-samesize.ll

  Log Message:
  -----------
  [LLD] [COFF] Fix handling of LTO comdats with nontrivial selection types after 728cc0075e5dfdb454eb

Commit 728cc0075e5dfdb454ebe6418b63bdffae71ec14 made comdat symbols
from LTO objects be treated as any regular comdat symbol. This works
great for symbols that actually are IMAGE_COMDAT_SELECT_ANY, but
if the symbols have a less trivial selection type that require comparing
either the section chunk size or contents, we can't check that before
actually doing the LTO compilation.

Therefore bring back one aspect of handling from before; that comdat
resolution with a leader from an LTO symbol is essentially skipped,
like it was before 728cc0075e5dfdb454ebe6418b63bdffae71ec14.

Differential Revision: https://reviews.llvm.org/D104605