[all-commits] [llvm/llvm-project] 3eed57: [ADT] Rename StringRef case insensitive methods fo...

Thu Jun 24 14:23:31 PDT 2021

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 3eed57e7ef7da5eda765ccc19fd26fb8dfcd8d41
      https://github.com/llvm/llvm-project/commit/3eed57e7ef7da5eda765ccc19fd26fb8dfcd8d41
  Author: Martin Storsjö <martin at martin.st>
  Date:   2021-06-25 (Fri, 25 Jun 2021)

  Changed paths:
    M llvm/include/llvm/ADT/StringRef.h
    M llvm/lib/Support/StringRef.cpp
    M llvm/unittests/ADT/StringRefTest.cpp

  Log Message:
  -----------
  [ADT] Rename StringRef case insensitive methods for clarity

Rename functions with the `xx_lower()` names to `xx_insensitive()`.
This was requested during the review of D104218.

Test names and variables in llvm/unittests/ADT/StringRefTest.cpp
that refer to "lower" are renamed to "insensitive" correspondingly.

Unused function aliases with the former method names are left
in place (without any deprecation attributes) for transition purposes.

All references within the monorepo will be changed (with essentially
mechanical changes), and then the old names will be removed in a
later commit.

Also remove the superfluous method names at the start of doxygen
comments, for the methods that are touched here. (There are more
occurrances of this left in other methods though.) Also remove
duplicate doxygen comments from the implementation file.

Differential Revision: https://reviews.llvm.org/D104819

  Commit: 42f74e824908f164f31e1d9e913dbd975d03fe4a
      https://github.com/llvm/llvm-project/commit/42f74e824908f164f31e1d9e913dbd975d03fe4a
  Author: Martin Storsjö <martin at martin.st>
  Date:   2021-06-25 (Fri, 25 Jun 2021)

  Changed paths:
    M llvm/include/llvm/ADT/SmallString.h
    M llvm/include/llvm/ADT/StringSwitch.h
    M llvm/include/llvm/Support/FormatProviders.h
    M llvm/include/llvm/Support/VirtualFileSystem.h
    M llvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp
    M llvm/lib/DebugInfo/PDB/Native/GSIStreamBuilder.cpp
    M llvm/lib/FileCheck/FileCheck.cpp
    M llvm/lib/MC/MCParser/AsmParser.cpp
    M llvm/lib/MC/MCParser/COFFMasmParser.cpp
    M llvm/lib/MC/MCParser/MasmParser.cpp
    M llvm/lib/Option/OptTable.cpp
    M llvm/lib/ProfileData/InstrProfReader.cpp
    M llvm/lib/Support/StringExtras.cpp
    M llvm/lib/Support/VirtualFileSystem.cpp
    M llvm/lib/Support/Windows/Path.inc
    M llvm/lib/Target/AArch64/AArch64ISelLowering.cpp
    M llvm/lib/Target/AArch64/AArch64MachineFunctionInfo.cpp
    M llvm/lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp
    M llvm/lib/Target/AMDGPU/AMDGPULibCalls.cpp
    M llvm/lib/Target/AMDGPU/AMDGPUSubtarget.cpp
    M llvm/lib/Target/ARM/ARMISelLowering.cpp
    M llvm/lib/Target/ARM/AsmParser/ARMAsmParser.cpp
    M llvm/lib/Target/Hexagon/AsmParser/HexagonAsmParser.cpp
    M llvm/lib/Target/Hexagon/MCTargetDesc/HexagonMCDuplexInfo.cpp
    M llvm/lib/Target/Lanai/AsmParser/LanaiAsmParser.cpp
    M llvm/lib/Target/MSP430/AsmParser/MSP430AsmParser.cpp
    M llvm/lib/Target/PowerPC/AsmParser/PPCAsmParser.cpp
    M llvm/lib/Target/PowerPC/PPCISelLowering.cpp
    M llvm/lib/Target/PowerPC/PPCTargetTransformInfo.cpp
    M llvm/lib/Target/Sparc/AsmParser/SparcAsmParser.cpp
    M llvm/lib/Target/Sparc/LeonPasses.cpp
    M llvm/lib/Target/WebAssembly/AsmParser/WebAssemblyAsmParser.cpp
    M llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp
    M llvm/lib/Target/X86/MCTargetDesc/X86MCTargetDesc.cpp
    M llvm/lib/Target/X86/X86ISelLowering.cpp
    M llvm/lib/ToolDrivers/llvm-dlltool/DlltoolDriver.cpp
    M llvm/tools/bugpoint/ToolRunner.cpp
    M llvm/tools/llvm-ar/llvm-ar.cpp
    M llvm/tools/llvm-cov/llvm-cov.cpp
    M llvm/tools/llvm-jitlink/llvm-jitlink.cpp
    M llvm/tools/llvm-objcopy/llvm-objcopy.cpp
    M llvm/tools/llvm-objdump/llvm-objdump.cpp
    M llvm/tools/llvm-pdbutil/DumpOutputStyle.cpp
    M llvm/tools/llvm-rc/ResourceFileWriter.cpp
    M llvm/tools/llvm-rc/ResourceScriptCppFilter.cpp
    M llvm/tools/llvm-rc/ResourceScriptParser.cpp
    M llvm/tools/llvm-rc/ResourceScriptStmt.h
    M llvm/tools/llvm-rc/ResourceScriptToken.cpp
    M llvm/tools/llvm-rc/llvm-rc.cpp
    M llvm/unittests/ADT/SmallStringTest.cpp
    M llvm/unittests/Support/CommandLineTest.cpp
    M llvm/utils/TableGen/AsmMatcherEmitter.cpp

  Log Message:
  -----------
  [llvm] Rename StringRef _lower() method calls to _insensitive()

This is a mechanical change. This actually also renames the
similarly named methods in the SmallString class, however these
methods don't seem to be used outside of the llvm subproject, so
this doesn't break building of the rest of the monorepo.

  Commit: e5c7c171e5db6af1e3dca1059df4287b0d147eaf
      https://github.com/llvm/llvm-project/commit/e5c7c171e5db6af1e3dca1059df4287b0d147eaf
  Author: Martin Storsjö <martin at martin.st>
  Date:   2021-06-25 (Fri, 25 Jun 2021)

  Changed paths:
    M clang/lib/ASTMatchers/Dynamic/Marshallers.cpp
    M clang/lib/Analysis/CalledOnceCheck.cpp
    M clang/lib/Analysis/RetainSummaryManager.cpp
    M clang/lib/Basic/FileManager.cpp
    M clang/lib/CodeGen/TargetInfo.cpp
    M clang/lib/Driver/Driver.cpp
    M clang/lib/Driver/ToolChains/Arch/RISCV.cpp
    M clang/lib/Driver/ToolChains/Clang.cpp
    M clang/lib/Driver/ToolChains/Fuchsia.cpp
    M clang/lib/Driver/ToolChains/Gnu.cpp
    M clang/lib/Driver/ToolChains/Hexagon.cpp
    M clang/lib/Driver/ToolChains/MSVC.cpp
    M clang/lib/Driver/ToolChains/MinGW.cpp
    M clang/lib/Format/Format.cpp
    M clang/lib/Format/SortJavaScriptImports.cpp
    M clang/lib/Format/UsingDeclarationsSorter.cpp
    M clang/lib/Frontend/CompilerInvocation.cpp
    M clang/lib/Lex/HeaderMap.cpp
    M clang/lib/Lex/PPDirectives.cpp
    M clang/lib/Lex/PPMacroExpansion.cpp
    M clang/lib/Sema/CodeCompleteConsumer.cpp
    M clang/lib/Sema/SemaChecking.cpp
    M clang/lib/Sema/SemaCodeComplete.cpp
    M clang/lib/StaticAnalyzer/Checkers/CStringChecker.cpp
    M clang/lib/StaticAnalyzer/Checkers/ContainerModeling.cpp
    M clang/lib/StaticAnalyzer/Checkers/GCDAntipatternChecker.cpp
    M clang/lib/StaticAnalyzer/Checkers/Iterator.cpp
    M clang/lib/StaticAnalyzer/Checkers/MallocChecker.cpp
    M clang/lib/Tooling/Inclusions/HeaderIncludes.cpp
    M clang/lib/Tooling/InterpolatingCompilationDatabase.cpp
    M clang/tools/clang-refactor/TestSupport.cpp
    M clang/tools/clang-scan-deps/ClangScanDeps.cpp
    M clang/tools/driver/driver.cpp
    M clang/tools/libclang/CIndexCodeCompletion.cpp
    M clang/unittests/Tooling/CompilationDatabaseTest.cpp

  Log Message:
  -----------
  [clang] Rename StringRef _lower() method calls to _insensitive()

This is mostly a mechanical change, but a testcase that contains
parts of the StringRef class (clang/test/Analysis/llvm-conventions.cpp)
isn't touched.

  Commit: 86029e4c220b91be728f6ff6a17cad098821e657
      https://github.com/llvm/llvm-project/commit/86029e4c220b91be728f6ff6a17cad098821e657
  Author: Martin Storsjö <martin at martin.st>
  Date:   2021-06-25 (Fri, 25 Jun 2021)

  Changed paths:
    M clang-tools-extra/clang-tidy/ClangTidyCheck.cpp
    M clang-tools-extra/clang-tidy/altera/KernelNameRestrictionCheck.cpp
    M clang-tools-extra/clang-tidy/bugprone/ArgumentCommentCheck.cpp
    M clang-tools-extra/clang-tidy/cppcoreguidelines/PreferMemberInitializerCheck.cpp
    M clang-tools-extra/clang-tidy/misc/StaticAssertCheck.cpp
    M clang-tools-extra/clang-tidy/readability/InconsistentDeclarationParameterNameCheck.cpp
    M clang-tools-extra/clang-tidy/readability/UppercaseLiteralSuffixCheck.cpp
    M clang-tools-extra/clangd/CodeComplete.cpp
    M clang-tools-extra/clangd/CompileCommands.cpp
    M clang-tools-extra/clangd/ConfigYAML.cpp
    M clang-tools-extra/clangd/HeaderSourceSwitch.cpp
    M clang-tools-extra/clangd/InlayHints.cpp
    M clang-tools-extra/clangd/Quality.cpp
    M clang-tools-extra/clangd/index/SymbolCollector.cpp
    M clang-tools-extra/clangd/support/Path.cpp
    M clang-tools-extra/modularize/ModularizeUtilities.cpp

  Log Message:
  -----------
  [clang-tools-extra] Rename StringRef _lower() method calls to _insensitive()

  Commit: 3c6f8ca7c9ac99f1606fd0fdd21487675bf3f715
      https://github.com/llvm/llvm-project/commit/3c6f8ca7c9ac99f1606fd0fdd21487675bf3f715
  Author: Martin Storsjö <martin at martin.st>
  Date:   2021-06-25 (Fri, 25 Jun 2021)

  Changed paths:
    M lld/COFF/DebugTypes.cpp
    M lld/COFF/Driver.cpp
    M lld/COFF/DriverUtils.cpp
    M lld/Common/Args.cpp
    M lld/ELF/Relocations.cpp
    M lld/ELF/ScriptParser.cpp
    M lld/MinGW/Driver.cpp
    M lld/lib/Driver/DarwinLdDriver.cpp
    M lld/tools/lld/lld.cpp

  Log Message:
  -----------
  [lld] Rename StringRef _lower() method calls to _insensitive()

  Commit: e50f9c419a84d1e58c38aa660c445395ad8056e6
      https://github.com/llvm/llvm-project/commit/e50f9c419a84d1e58c38aa660c445395ad8056e6
  Author: Martin Storsjö <martin at martin.st>
  Date:   2021-06-25 (Fri, 25 Jun 2021)

  Changed paths:
    M lldb/source/Commands/CommandObjectMultiword.cpp
    M lldb/source/Host/common/NativeRegisterContext.cpp
    M lldb/source/Host/windows/ProcessLauncherWindows.cpp
    M lldb/source/Initialization/SystemInitializerCommon.cpp
    M lldb/source/Interpreter/CommandInterpreter.cpp
    M lldb/source/Interpreter/CommandObject.cpp
    M lldb/source/Interpreter/OptionArgParser.cpp
    M lldb/source/Interpreter/OptionValueProperties.cpp
    M lldb/source/Interpreter/ScriptInterpreter.cpp
    M lldb/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp
    M lldb/source/Plugins/Language/ObjC/ObjCLanguage.cpp
    M lldb/source/Plugins/Language/ObjCPlusPlus/ObjCPlusPlusLanguage.cpp
    M lldb/source/Plugins/Process/Windows/Common/ProcessWindows.cpp
    M lldb/source/Plugins/Process/minidump/ProcessMinidump.cpp
    M lldb/source/Plugins/SymbolFile/NativePDB/CompileUnitIndex.cpp
    M lldb/source/Plugins/SymbolFile/NativePDB/PdbFPOProgramToDWARFExpression.cpp
    M lldb/source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp
    M lldb/source/Target/Language.cpp
    M lldb/source/Target/RegisterContext.cpp
    M lldb/source/Utility/ArchSpec.cpp
    M lldb/source/Utility/ConstString.cpp
    M lldb/source/Utility/FileSpec.cpp
    M lldb/source/Utility/Log.cpp

  Log Message:
  -----------
  [lldb] Rename StringRef _lower() method calls to _insensitive()

  Commit: 9264728450c350a3e581e9914c4a26ddccdba0d1
      https://github.com/llvm/llvm-project/commit/9264728450c350a3e581e9914c4a26ddccdba0d1
  Author: Martin Storsjö <martin at martin.st>
  Date:   2021-06-25 (Fri, 25 Jun 2021)

  Changed paths:
    M mlir/test/lib/Dialect/Test/TestTypes.cpp

  Log Message:
  -----------
  [mlir] Rename StringRef _lower() method calls to _insensitive()

  Commit: 2e4a2b8430aca6f7aef8100a5ff81ca0328d03f9
      https://github.com/llvm/llvm-project/commit/2e4a2b8430aca6f7aef8100a5ff81ca0328d03f9
  Author: Martin Storsjö <martin at martin.st>
  Date:   2021-06-25 (Fri, 25 Jun 2021)

  Changed paths:
    M llvm/include/llvm/ADT/StringRef.h

  Log Message:
  -----------
  [ADT] Complete the StringRef case insensitive method renaming

Remove the old name for the methods. These were only left behind to
ease the transition for downstreams.

Differential Revision: https://reviews.llvm.org/D104820

Compare: https://github.com/llvm/llvm-project/compare/d09218a82e1a...2e4a2b8430ac