[all-commits] [llvm/llvm-project] 4a8503: [lld-macho] Align all cstrings to 16 bytes when de...

Jez Ng via All-commits all-commits at lists.llvm.org
Thu Jun 24 13:53:45 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 4a8503c8e04a5252193d58bb57a0111e7df05104
      https://github.com/llvm/llvm-project/commit/4a8503c8e04a5252193d58bb57a0111e7df05104
  Author: Jez Ng <jezng at fb.com>
  Date:   2021-06-24 (Thu, 24 Jun 2021)

  Changed paths:
    M lld/MachO/SyntheticSections.cpp

  Log Message:
  -----------
  [lld-macho] Align all cstrings to 16 bytes when deduplicating

We previously did this only for x86_64, but it turns out that
arm64 needs this too -- see PR50791.

Ultimately this is a hack, and we should avoid over-aligning strings
that don't need it. I'm just having a hard time figuring out how ld64 is
determining the right alignment.

No new test for this since we were already testing this behavior for
x86_64, and extending it to arm64 seems too trivial.

Reviewed By: #lld-macho, thakis

Differential Revision: https://reviews.llvm.org/D104835




More information about the All-commits mailing list