[all-commits] [llvm/llvm-project] 8db0db: [CodeGen] Don't create fake FunctionDecls when gen...

[Akira Hatanaka via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 8db0dbbe2c0544c38f33cf64b4cdd5135d524b23
      https://github.com/llvm/llvm-project/commit/8db0dbbe2c0544c38f33cf64b4cdd5135d524b23
  Author: Akira Hatanaka <ahatanaka at apple.com>
  Date:   2021-06-24 (Thu, 24 Jun 2021)

  Changed paths:
    M clang/lib/CodeGen/CGBlocks.cpp
    M clang/test/CodeGenCXX/debug-info-blocks.cpp
    M clang/test/CodeGenObjC/block-byref-debuginfo.m
    M clang/test/CodeGenObjC/debug-info-block-helper.m
    M clang/test/CodeGenObjC/debug-info-blocks.m

  Log Message:
  -----------
  [CodeGen] Don't create fake FunctionDecls when generating block/byref
copy/dispose helper functions

We found out that these fake functions would cause clang to crash if the
changes proposed in https://reviews.llvm.org/D98799 were made.

The original patch was reverted in f681fd927e883301658dcac9a78109ee0aba12a8
because debug locations were missing in the body of the block byref
helper functions. This patch fixes the bug by calling CreateArtificial
after the calls to StartFunction.

Differential Revision: https://reviews.llvm.org/D104082