[all-commits] [llvm/llvm-project] 0c0628: [libc++] Remove ad-hoc modules tests that are now ...

Louis Dionne via All-commits all-commits at lists.llvm.org
Wed Jun 23 06:43:09 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 0c0628c92c0d3638f5739ecb28ba554347feccdf
      https://github.com/llvm/llvm-project/commit/0c0628c92c0d3638f5739ecb28ba554347feccdf
  Author: Louis Dionne <ldionne.2 at gmail.com>
  Date:   2021-06-23 (Wed, 23 Jun 2021)

  Changed paths:
    R libcxx/test/libcxx/modules/cinttypes_exports.compile.pass.cpp
    R libcxx/test/libcxx/modules/clocale_exports.compile.pass.cpp
    R libcxx/test/libcxx/modules/cstdint_exports.compile.pass.cpp
    R libcxx/test/libcxx/modules/inttypes_h_exports.compile.pass.cpp
    R libcxx/test/libcxx/modules/stdint_h_exports.compile.pass.cpp
    R libcxx/test/libcxx/modules/stds_include.sh.cpp
    M libcxx/utils/libcxx/test/features.py

  Log Message:
  -----------
  [libc++] Remove ad-hoc modules tests that are now unnecessary

Since we now have modules-enabled CI, it is now redundant to have ad-hoc
tests that check arbitrary things about our modules support. Instead,
the whole test suite should pass with modules enabled, period.

This patch also removes the module cache path workaround: one would
expect that modules work properly without that workaround. If that
isn't the case and we do run into flaky test failures, we can re-enable
the workaround temporarily (but that would be very vexing and we should
fix Clang ASAP if that's the case).

Differential Revision: https://reviews.llvm.org/D104746




More information about the All-commits mailing list