[all-commits] [llvm/llvm-project] 610d47: [lldb-vscode] only report long running progress ev...

[walter erquinigo via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 610d474cfd82f11dc4702e2cf1b2485584d7c243
      https://github.com/llvm/llvm-project/commit/610d474cfd82f11dc4702e2cf1b2485584d7c243
  Author: Walter Erquinigo <a20012251 at gmail.com>
  Date:   2021-06-21 (Mon, 21 Jun 2021)

  Changed paths:
    M lldb/tools/lldb-vscode/ProgressEvent.cpp
    M lldb/tools/lldb-vscode/ProgressEvent.h
    M lldb/tools/lldb-vscode/VSCode.cpp
    M lldb/tools/lldb-vscode/VSCode.h
    M lldb/tools/lldb-vscode/lldb-vscode.cpp

  Log Message:
  -----------
  [lldb-vscode] only report long running progress events

When the number of shared libs is massive, there could be hundreds of
thousands of short lived progress events sent to the IDE, which makes it
irresponsive while it's processing all this data. As these small jobs
take less than a second to process, the user doesn't even see them,
because the IDE only display the progress of long operations. So it's
better not to send these events.

I'm fixing that by sending only the events that are taking longer than 5
seconds to process.
In a specific run, I got the number of events from ~500k to 100, because
there was only 1 big lib to parse.

I've tried this on several small and massive targets, and it seems to
work fine.

Differential Revision: https://reviews.llvm.org/D101128


  Commit: 2e11f4e06804e53cee95e63fdc9e5152f8444abb
      https://github.com/llvm/llvm-project/commit/2e11f4e06804e53cee95e63fdc9e5152f8444abb
  Author: Walter Erquinigo <wallace at fb.com>
  Date:   2021-06-21 (Mon, 21 Jun 2021)

  Changed paths:
    M lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/vscode.py

  Log Message:
  -----------
  [lldb-vscode] Add simple DAP logs dump to investigate flakiness in tests

A few times tests have been flaky, presumably by crashed of lldb-vscode
itself. They can be caught by looking at the DAP logs, so I'm dumping
them when the session ends.


Compare: https://github.com/llvm/llvm-project/compare/74909e4b6e9b...2e11f4e06804