[all-commits] [llvm/llvm-project] decfad: Revert "Re-Revert "DirectoryWatcher: add an implem...

[Saleem Abdulrasool via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: decfad7d8e9b268654dd2d76a7f5f777502b60a6
      https://github.com/llvm/llvm-project/commit/decfad7d8e9b268654dd2d76a7f5f777502b60a6
  Author: Saleem Abdulrasool <compnerd at compnerd.org>
  Date:   2021-06-19 (Sat, 19 Jun 2021)

  Changed paths:
    M clang/lib/DirectoryWatcher/windows/DirectoryWatcher-windows.cpp
    M clang/unittests/DirectoryWatcher/CMakeLists.txt

  Log Message:
  -----------
  Revert "Re-Revert "DirectoryWatcher: add an implementation for Windows""

This reverts commit fb32de9e97af0921242a021e30020ffacf7aa6e2.

Remove the secondary synchronization point as noted by Adrian.  This is
technically only to make the builders happier about tests and should not
be needed.  This also pushes the condition variable setting to after the
watch is actually established (which was the source of the original race
condition, but would normally succeed as the thread shouldn't get put to
sleep immediately on the trigger of the condition variable).

This also was pretested on the chromium builders:
https://ci.chromium.org/ui/p/chromium/builders/try/win_upload_clang/1612/overview.