[all-commits] [llvm/llvm-project] c9889c: [clang-cl] Don't expand /permissive- to /ZC:strict...

zero9178 via All-commits all-commits at lists.llvm.org
Sat Jun 19 04:28:50 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: c9889c44ec5a4054833457c813e155f284703ef4
      https://github.com/llvm/llvm-project/commit/c9889c44ec5a4054833457c813e155f284703ef4
  Author: Markus Böck <markus.boeck02 at gmail.com>
  Date:   2021-06-19 (Sat, 19 Jun 2021)

  Changed paths:
    M clang/lib/Driver/ToolChains/MSVC.cpp

  Log Message:
  -----------
  [clang-cl] Don't expand /permissive- to /ZC:strictStrings yet

Follow up on rGc70b0e808da8

/Zc:strictStrings is an alias to an option part of the -W group. When the driver tries to render the option back to a string for the cc1 invocation, it sadly gets rendered with the original spelling instead of the alias, causing issues reported here: https://reviews.llvm.org/D103773#inline-989447

I am thinking it's the best to revert this part of the patch until I figured out how to correctly add the arg and until /Zc:strictStrings- exists/is needed.




More information about the All-commits mailing list